-
Notifications
You must be signed in to change notification settings - Fork 10
Update politique.component.html #3886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR updates the contact information in the privacy policy from an email address to a contact form URL. While the change appears to modernize the contact method, there are accessibility and semantic issues that should be addressed to improve user experience.
<p> | ||
Vous pouvez exercer ces droits en écrivant à | ||
<strong>dpd-minsociaux [at] sg.social.gouv.fr</strong> | ||
<strong>https://domifa.fabrique.social.gouv.fr/contact</strong> | ||
</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contact URL should be made clickable for better accessibility and user experience. Currently, users would need to manually copy and paste the URL. Additionally, consider updating the preceding text from 'en écrivant à' (by writing to) to better reflect that users are being directed to a contact form rather than writing an email.
<p> | |
Vous pouvez exercer ces droits en écrivant à | |
<strong>dpd-minsociaux [at] sg.social.gouv.fr</strong> | |
<strong>https://domifa.fabrique.social.gouv.fr/contact</strong> | |
</p> | |
<p> | |
Vous pouvez exercer ces droits en utilisant | |
<a href="https://domifa.fabrique.social.gouv.fr/contact"> | |
<strong>notre formulaire de contact</strong> | |
</a> | |
</p> |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3886 +/- ##
=======================================
Coverage 65.12% 65.12%
=======================================
Files 976 976
Lines 16577 16577
Branches 2307 2303 -4
=======================================
Hits 10795 10795
Misses 5431 5431
Partials 351 351 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
MAJ adresse email de contact