Skip to content

Conversation

Lycia-r
Copy link
Contributor

@Lycia-r Lycia-r commented Sep 5, 2025

MAJ adresse email de contact

@revu-bot revu-bot bot requested a review from revu-bot September 5, 2025 15:00
@Lycia-r Lycia-r requested a review from pYassine September 5, 2025 15:00
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR updates the contact information in the privacy policy from an email address to a contact form URL. While the change appears to modernize the contact method, there are accessibility and semantic issues that should be addressed to improve user experience.

Comment on lines 108 to 111
<p>
Vous pouvez exercer ces droits en écrivant à
<strong>dpd-minsociaux [at] sg.social.gouv.fr</strong>
<strong>https://domifa.fabrique.social.gouv.fr/contact</strong>
</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contact URL should be made clickable for better accessibility and user experience. Currently, users would need to manually copy and paste the URL. Additionally, consider updating the preceding text from 'en écrivant à' (by writing to) to better reflect that users are being directed to a contact form rather than writing an email.

Suggested change
<p>
Vous pouvez exercer ces droits en écrivant à
<strong>dpd-minsociaux [at] sg.social.gouv.fr</strong>
<strong>https://domifa.fabrique.social.gouv.fr/contact</strong>
</p>
<p>
Vous pouvez exercer ces droits en utilisant
<a href="https://domifa.fabrique.social.gouv.fr/contact">
<strong>notre formulaire de contact</strong>
</a>
</p>

Copy link

sonarqubecloud bot commented Sep 5, 2025

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.12%. Comparing base (7e5e571) to head (659eeaa).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3886   +/-   ##
=======================================
  Coverage   65.12%   65.12%           
=======================================
  Files         976      976           
  Lines       16577    16577           
  Branches     2307     2303    -4     
=======================================
  Hits        10795    10795           
  Misses       5431     5431           
  Partials      351      351           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5e571...659eeaa. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tokenbureau
Copy link

tokenbureau bot commented Sep 5, 2025

🎉 Deployment for commit 659eeaa :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-659eeaa8494541c499d36963b472f8e8c61992e9
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-659eeaa8494541c499d36963b472f8e8c61992e9
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-659eeaa8494541c499d36963b472f8e8c61992e9
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-659eeaa8494541c499d36963b472f8e8c61992e9
Debug

@pYassine pYassine closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants