Skip to content

Conversation

hbalty
Copy link
Contributor

@hbalty hbalty commented Sep 9, 2025

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot September 9, 2025 08:51
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR improves logging for user creation by adding userId and structureId to the audit log. The changes move from mocked testing to integration testing with actual database verification, which is a quality improvement. However, there are some concerns around type safety, test coverage completeness, and potential performance implications of the test cleanup strategy.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.12%. Comparing base (cd92224) to head (b77b402).
⚠️ Report is 2 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3894   +/-   ##
=======================================
  Coverage   65.12%   65.12%           
=======================================
  Files         976      976           
  Lines       16577    16578    +1     
  Branches     2311     2308    -3     
=======================================
+ Hits        10795    10796    +1     
  Misses       5572     5572           
  Partials      210      210           
Files with missing lines Coverage Δ
.../src/modules/users/controllers/users.controller.ts 60.00% <100.00%> (+0.50%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd92224...b77b402. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hbalty hbalty force-pushed the fix-log-users-actions branch from e5f1cc4 to 6e34934 Compare September 9, 2025 09:01
@hbalty hbalty temporarily deployed to build-review-auto September 9, 2025 09:01 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto September 9, 2025 09:01 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto September 9, 2025 09:01 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto September 9, 2025 09:01 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto September 9, 2025 12:29 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto September 9, 2025 12:29 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto September 9, 2025 12:29 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto September 9, 2025 12:29 — with GitHub Actions Inactive
Copy link

sonarqubecloud bot commented Sep 9, 2025

@tokenbureau
Copy link

tokenbureau bot commented Sep 9, 2025

🎉 Deployment for commit b77b402 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-b77b402aa11263469398821409b493e25233beec
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-b77b402aa11263469398821409b493e25233beec
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-b77b402aa11263469398821409b493e25233beec
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-b77b402aa11263469398821409b493e25233beec
Debug

@pYassine pYassine merged commit 1af7892 into master Sep 17, 2025
19 checks passed
@pYassine pYassine deleted the fix-log-users-actions branch September 17, 2025 16:33
@tokenbureau
Copy link

tokenbureau bot commented Sep 17, 2025

🎉 This PR is included in version 2.220.19 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants