-
Notifications
You must be signed in to change notification settings - Fork 10
fix(backend): adding userId and structureId to user create log #3894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR improves logging for user creation by adding userId and structureId to the audit log. The changes move from mocked testing to integration testing with actual database verification, which is a quality improvement. However, there are some concerns around type safety, test coverage completeness, and potential performance implications of the test cleanup strategy.
packages/backend/src/modules/users/controllers/users.controller.spec.ts
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3894 +/- ##
=======================================
Coverage 65.12% 65.12%
=======================================
Files 976 976
Lines 16577 16578 +1
Branches 2311 2308 -3
=======================================
+ Hits 10795 10796 +1
Misses 5572 5572
Partials 210 210
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
e5f1cc4
to
6e34934
Compare
|
🎉 This PR is included in version 2.220.19 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.