Skip to content

Conversation

pYassine
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 43.70370% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.41%. Comparing base (1cc06f4) to head (f4481f5).

Files with missing lines Patch % Lines
...d/src/app/interceptors/server-error.interceptor.ts 0.00% 22 Missing and 8 partials ⚠️
...nd/src/app/modules/shared/services/auth.service.ts 7.14% 12 Missing and 1 partial ⚠️
packages/frontend/src/app/guards/auth.guard.ts 33.33% 9 Missing and 3 partials ⚠️
...usagers/controllers/usagers-decision.controller.ts 0.00% 3 Missing and 1 partial ⚠️
...ge-usagers-table/manage-usagers-table.component.ts 0.00% 3 Missing and 1 partial ⚠️
...structures/controllers/structure-doc.controller.ts 33.33% 2 Missing ⚠️
...dules/users/controllers/users.public.controller.ts 33.33% 2 Missing ⚠️
...rs/controllers/usager-structure-docs.controller.ts 33.33% 2 Missing ⚠️
.../src/modules/users/controllers/users.controller.ts 85.71% 1 Missing ⚠️
...ckend/src/usagers/controllers/agenda.controller.ts 50.00% 1 Missing ⚠️
... and 5 more
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3904      +/-   ##
==========================================
+ Coverage   64.86%   65.41%   +0.55%     
==========================================
  Files         981      964      -17     
  Lines       16689    16469     -220     
  Branches     2332     2287      -45     
==========================================
- Hits        10825    10773      -52     
+ Misses       5675     5352     -323     
- Partials      189      344     +155     
Files with missing lines Coverage Δ
...nd/src/_common/model/users/user-structure/index.ts 100.00% <ø> (ø)
...backend/src/auth/guards/usager-doc-access.guard.ts 85.00% <100.00%> (ø)
.../auth/structures-auth.controller.security-tests.ts 100.00% <100.00%> (ø)
...ges/backend/src/auth/structures-auth.controller.ts 85.71% <100.00%> (+0.86%) ⬆️
...ractions/interactions.controller.security-tests.ts 100.00% <100.00%> (ø)
...rc/modules/interactions/interactions.controller.ts 71.42% <ø> (-0.80%) ⬇️
...ail-admin/dto/register-user-structure-admin.dto.ts 95.45% <100.00%> (ø)
...gers-manager/portail-usagers-manager.controller.ts 20.90% <100.00%> (-0.72%) ⬇️
...d/src/modules/sms/sms.controller.security-tests.ts 100.00% <100.00%> (ø)
packages/backend/src/modules/sms/sms.controller.ts 66.66% <100.00%> (-2.09%) ⬇️
... and 60 more

... and 56 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc06f4...f4481f5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pYassine pYassine temporarily deployed to build-review-auto September 16, 2025 13:09 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto September 16, 2025 13:09 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto September 16, 2025 13:09 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto September 16, 2025 13:09 — with GitHub Actions Inactive
@pYassine pYassine marked this pull request as ready for review September 16, 2025 14:52
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurred: ## ⚠️ PR Review Skipped

Issues Found

1. This PR changes 67 files, which exceeds the limit of 25 files.

Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.

PR Metrics

  • Total files changed: 67
  • Reviewable files: 67
  • Diff size: 1975 lines
  • Documentation files: 0
  • Largest file change: 300 lines
  • Addition/Deletion ratio: 1.52

This validation helps ensure the bot focuses on PRs where automated review provides the most value. You can adjust these limits in your .revu.yml configuration file.

Revu logs

Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurred: ## ⚠️ PR Review Skipped

Issues Found

1. This PR changes 82 files, which exceeds the limit of 25 files.

Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.

PR Metrics

  • Total files changed: 82
  • Reviewable files: 82
  • Diff size: 2558 lines
  • Documentation files: 0
  • Largest file change: 301 lines
  • Addition/Deletion ratio: 1.30

This validation helps ensure the bot focuses on PRs where automated review provides the most value. You can adjust these limits in your .revu.yml configuration file.

Revu logs

@pYassine pYassine requested a review from hbalty September 18, 2025 07:36
Copy link
Contributor

@hbalty hbalty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si tu peux ajouter des cas de tests front pour les guard avec le nouveau role

Copy link

@tokenbureau
Copy link

tokenbureau bot commented Sep 18, 2025

🎉 Deployment for commit f4481f5 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-f4481f5d8a15131000c42fa1f917fb5ecc47bfb1
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-f4481f5d8a15131000c42fa1f917fb5ecc47bfb1
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-f4481f5d8a15131000c42fa1f917fb5ecc47bfb1
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-f4481f5d8a15131000c42fa1f917fb5ecc47bfb1
Debug

@pYassine pYassine merged commit 83daed5 into master Sep 18, 2025
19 checks passed
@pYassine pYassine deleted the feat-new-role branch September 18, 2025 14:38
@tokenbureau
Copy link

tokenbureau bot commented Sep 18, 2025

🎉 This PR is included in version 2.221.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants