Feat integrating static pages - frontend #3909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbalty
force-pushed
the
feat-start-dsfr
branch
2 times, most recently
from
836e0e5 to
413639b
Compare
pYassine
reviewed
Sep 18, 2025
packages/frontend/src/app/modules/general/components/faq/faq.component.ts
Outdated
Show resolved
Hide resolved
pYassine
reviewed
Sep 18, 2025
...es/frontend/src/app/modules/general/components/static-pages/politique/politique.component.ts
Show resolved
Hide resolved
hbalty
force-pushed
the
feat-integrating-static-pages
branch
from
a27fad9 to
0ce2e0f
Compare
hbalty
had a problem deploying
to
build-review-auto
GitHub Actions
Failure
hbalty
had a problem deploying
to
build-review-auto
GitHub Actions
Failure
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
hbalty
had a problem deploying
to
build-review-auto
GitHub Actions
Failure
hbalty
changed the title
revu-bot
reviewed
Sep 18, 2025
There was a problem hiding this comment.
This PR refactors static pages to integrate the French government design system (DSFR). The main changes include removing styled headers, replacing HTML tables with DSFR components, and updating CSS. While the integration looks comprehensive, there are several issues that could impact visual consistency and data quality.
revu-bot
reviewed
Sep 18, 2025
revu-bot
reviewed
Sep 18, 2025
.../frontend/src/app/modules/general/components/static-pages/politique/politique.component.html
Show resolved
Hide resolved
revu-bot
reviewed
Sep 18, 2025
| </div> | ||
|
|
||
| <div class="content py-3" *ngIf="contactForm && !success"> | ||
| <div class="py-3" *ngIf="contactForm && !success"> |
There was a problem hiding this comment.
The contact form title was moved from a styled header to regular content. Ensure the h1 styling is appropriate and maintains visual hierarchy for accessibility.
There was a problem hiding this comment.
@pYassine c'était un choix, parce qu'on affichait un message parachuté avec un header parachuté.
revu-bot
reviewed
Sep 18, 2025
packages/frontend/src/app/modules/general/components/faq/faq.component.html
Show resolved
Hide resolved
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
hbalty
force-pushed
the
feat-start-dsfr
branch
from
413639b to
2654843
Compare
hbalty
force-pushed
the
feat-integrating-static-pages
branch
from
0ce2e0f to
53f3869
Compare
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
hbalty
had a problem deploying
to
build-review-auto
GitHub Actions
Failure
hbalty
had a problem deploying
to
build-review-auto
GitHub Actions
Failure
hbalty
had a problem deploying
to
build-review-auto
GitHub Actions
Failure
hbalty
force-pushed
the
feat-integrating-static-pages
branch
from
53f3869 to
e425ab9
Compare
hbalty
had a problem deploying
to
build-review-auto
GitHub Actions
Failure
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
hbalty
had a problem deploying
to
build-review-auto
GitHub Actions
Failure
hbalty
had a problem deploying
to
build-review-auto
GitHub Actions
Failure
hbalty
force-pushed
the
feat-integrating-static-pages
branch
from
e425ab9 to
5e7b2fb
Compare
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
hbalty
had a problem deploying
to
build-review-auto
GitHub Actions
Failure
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
hbalty
force-pushed
the
feat-start-dsfr
branch
from
2da0975 to
2147861
Compare
hbalty
force-pushed
the
feat-integrating-static-pages
branch
from
8127177 to
cc5aa2d
Compare
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
pYassine
reviewed
Sep 23, 2025
packages/frontend/src/app/modules/general/components/plan-site/plan-site.component.html
Show resolved
Hide resolved
pYassine
approved these changes
Sep 23, 2025
revu-bot
reviewed
Sep 23, 2025
There was a problem hiding this comment.
This PR implements a significant refactoring to integrate DSFR (Design System of French Republic) components into static pages. While the integration appears well-structured, there are several important issues that need attention: data quality problems in the FAQ component, potentially breaking CSS changes that could affect other components, and layout inconsistencies that may impact accessibility and user experience.
revu-bot
reviewed
Sep 23, 2025
packages/frontend/src/app/modules/general/components/faq/faq.component.ts
Show resolved
Hide resolved
revu-bot
reviewed
Sep 23, 2025
packages/frontend/src/app/modules/general/components/static-pages/cgu/cgu.component.html
Show resolved
Hide resolved
…omponent.ts Co-authored-by: Revu <dnum.fabrique@sg.social.gouv.fr>
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
hbalty
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
|
hbalty
had a problem deploying
to
review-auto
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.