-
Notifications
You must be signed in to change notification settings - Fork 10
🐛 bug - add referrer in creation #3912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds referrer validation during user creation, which is a good security improvement. However, there are critical issues with response handling patterns in the controller that need to be addressed. The controller mixes direct response handling with return values, creating inconsistent API behavior.
packages/backend/src/usagers/services/usagersCreator.service.ts
Outdated
Show resolved
Hide resolved
40c1c9d
to
4345889
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3912 +/- ##
==========================================
+ Coverage 64.82% 64.85% +0.03%
==========================================
Files 980 981 +1
Lines 16662 16683 +21
Branches 2328 2330 +2
==========================================
+ Hits 10801 10820 +19
- Misses 5502 5674 +172
+ Partials 359 189 -170
... and 73 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
packages/backend/src/usagers/controllers/tests/usagers.controller.spec.ts
Outdated
Show resolved
Hide resolved
4345889
to
89463e8
Compare
|
🎉 This PR is included in version 2.220.20 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.