Skip to content

Conversation

pYassine
Copy link
Contributor

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot September 16, 2025 10:07
@pYassine pYassine marked this pull request as ready for review September 16, 2025 10:07
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds referrer validation during user creation, which is a good security improvement. However, there are critical issues with response handling patterns in the controller that need to be addressed. The controller mixes direct response handling with return values, creating inconsistent API behavior.

@pYassine pYassine temporarily deployed to build-review-auto September 16, 2025 10:13 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto September 16, 2025 10:13 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto September 16, 2025 10:13 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto September 16, 2025 10:13 — with GitHub Actions Inactive
@pYassine pYassine changed the title Fix referrers creation 🐛 bug - add referrer in creation Sep 16, 2025
@pYassine pYassine temporarily deployed to build-review-auto September 16, 2025 14:51 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto September 16, 2025 14:51 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto September 16, 2025 14:51 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto September 16, 2025 14:51 — with GitHub Actions Inactive
@pYassine pYassine force-pushed the fix-referrers-creation branch from 40c1c9d to 4345889 Compare September 17, 2025 09:17
@pYassine pYassine temporarily deployed to build-review-auto September 17, 2025 09:17 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto September 17, 2025 09:17 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto September 17, 2025 09:17 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto September 17, 2025 09:17 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.85%. Comparing base (7229910) to head (89463e8).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...kend/src/usagers/controllers/usagers.controller.ts 76.92% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3912      +/-   ##
==========================================
+ Coverage   64.82%   64.85%   +0.03%     
==========================================
  Files         980      981       +1     
  Lines       16662    16683      +21     
  Branches     2328     2330       +2     
==========================================
+ Hits        10801    10820      +19     
- Misses       5502     5674     +172     
+ Partials      359      189     -170     
Files with missing lines Coverage Δ
...modules/sms/services/message-sms-sender.service.ts 21.42% <ø> (+0.49%) ⬆️
...ecurity-tests/usagers.controller.security-tests.ts 100.00% <100.00%> (ø)
.../usagers/services/tests/CREATE_USAGER_DTO.const.ts 100.00% <100.00%> (ø)
...end/src/usagers/services/usagersCreator.service.ts 95.45% <100.00%> (ø)
...kend/src/usagers/controllers/usagers.controller.ts 54.54% <76.92%> (+0.88%) ⬆️

... and 73 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7229910...89463e8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pYassine pYassine requested a review from hbalty September 17, 2025 10:29
Copy link

@pYassine pYassine merged commit 8057688 into master Sep 17, 2025
18 of 19 checks passed
@pYassine pYassine deleted the fix-referrers-creation branch September 17, 2025 19:21
@tokenbureau
Copy link

tokenbureau bot commented Sep 17, 2025

🎉 This PR is included in version 2.220.20 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants