-
Notifications
You must be signed in to change notification settings - Fork 10
fix(logs): using usagers row instead of previewTable for total count #3913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR correctly fixes logging inconsistencies in the import preview functionality. The changes align the preview mode logging with the success mode logging by using usagersRows.length
(valid usagers) instead of importPreviewRows.length
(all rows) for the total count, and properly updates the action name to reflect it's a preview operation. The changes are focused and semantically correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dans le previewTable qu'on envoie au client, si l'info est mauvaise c'est ce qui va être envoyé au client et affiché dans le front :
{{ previewTable.totalCount }} domiciliés seront importés sur DomiFa
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3913 +/- ##
========================================
Coverage 64.82% 64.82%
========================================
Files 980 980
Lines 16661 16666 +5
Branches 2327 2329 +2
========================================
+ Hits 10800 10804 +4
+ Misses 5672 5503 -169
- Partials 189 359 +170
... and 75 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…if count in service
|
🎉 This PR is included in version 2.220.18 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.