Skip to content

Conversation

hbalty
Copy link
Contributor

@hbalty hbalty commented Sep 16, 2025

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot September 16, 2025 13:41
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR correctly fixes logging inconsistencies in the import preview functionality. The changes align the preview mode logging with the success mode logging by using usagersRows.length (valid usagers) instead of importPreviewRows.length (all rows) for the total count, and properly updates the action name to reflect it's a preview operation. The changes are focused and semantically correct.

Copy link
Contributor Author

@hbalty hbalty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dans le previewTable qu'on envoie au client, si l'info est mauvaise c'est ce qui va être envoyé au client et affiché dans le front :
{{ previewTable.totalCount }} domiciliés seront importés sur DomiFa

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.82%. Comparing base (4304077) to head (c173b5c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...rc/usagers/controllers/import/import.controller.ts 66.66% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #3913    +/-   ##
========================================
  Coverage   64.82%   64.82%            
========================================
  Files         980      980            
  Lines       16661    16666     +5     
  Branches     2327     2329     +2     
========================================
+ Hits        10800    10804     +4     
+ Misses       5672     5503   -169     
- Partials      189      359   +170     
Files with missing lines Coverage Δ
...mport/step3-create/usagersImportCreator.service.ts 100.00% <100.00%> (ø)
...rc/usagers/controllers/import/import.controller.ts 86.86% <66.66%> (-1.02%) ⬇️

... and 75 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4304077...c173b5c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hbalty hbalty temporarily deployed to build-review-auto September 17, 2025 14:49 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto September 17, 2025 14:49 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto September 17, 2025 14:49 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto September 17, 2025 14:49 — with GitHub Actions Inactive
Copy link

@hbalty hbalty requested a review from pYassine September 17, 2025 14:51
@pYassine pYassine merged commit 41fd765 into master Sep 17, 2025
18 of 19 checks passed
@pYassine pYassine deleted the fix-logs-import-domicilies branch September 17, 2025 16:29
@tokenbureau
Copy link

tokenbureau bot commented Sep 17, 2025

🎉 This PR is included in version 2.220.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants