Feat dsfr page connexion mon domifa #3935
Conversation
There was a problem hiding this comment.
This PR implements a DSFR (Design System of the French Republic) redesign for the login page in the portail-usagers package. The changes include significant UI/UX improvements with new components, styling, and layout. However, there are several critical issues that need attention: duplicate module imports in the shared module, debugging code left in production, and potential accessibility concerns with form validation.
| }; | ||
| } | ||
|
|
||
| public onClick(event: Event) { |
There was a problem hiding this comment.
Critical: Debug code with console.log should not be committed to production. This method appears to be leftover debugging code and should be removed entirely.
| <dsfr-form-input | ||
| appUppercase | ||
| inputId="login" | ||
| type="email" |
There was a problem hiding this comment.
Important: The input type is set to 'email' but the field is labeled as 'identifiant' (identifier). This creates a semantic mismatch and may cause accessibility issues. If this field accepts non-email identifiers, use type='text' instead.
| type="email" | |
| type="text" |
| [disabled]="this.mode === 'login-change-password'" | ||
| [message]=" | ||
| f.login.dirty && f.login.errors | ||
| ? 'Veuillez vérifier l\'identifiant. Celui-ci se trouve sur le document que vous à remit la structure.' |
There was a problem hiding this comment.
Important: The error message contains a grammatical error that affects user experience. 'que vous à remit' should be 'que vous a remis'.
| ? 'Veuillez vérifier l\'identifiant. Celui-ci se trouve sur le document que vous à remit la structure.' | |
| ? 'Veuillez vérifier l\'identifiant. Celui-ci se trouve sur le document que vous a remis la structure.' |
|
No description provided.