feat(status-item): integrate new status-item design #444

LucasCharrier · 2025-09-08T16:02:18Z

WIP: j'attends des précisions de Melissa

revu-bot

This PR introduces a new status item design with significant refactoring of the CircledIcon component and a new NewStatusItem component. However, the implementation contains several critical issues including hardcoded placeholder data, missing React keys, potential memory leaks, and extensive commented-out code that suggests the feature is incomplete. The NewStatusItem component appears to contain debugging/placeholder code that shouldn't be in production.

revu-bot · 2025-09-08T16:03:24Z

app/src/scenes/status/NewStatusItem.tsx

+        {[0, 1, 2, 3].map((item) => (
+          <View className="flex-1 flex-row items-center mb-2">
+            <View className="h-3 w-3 rounded-full mr-2 bg-red"></View>
+            <View>
+              <Text>Anxiété, Irritabilité</Text>
+            </View>


This hardcoded text and the map over [0,1,2,3] appears to be placeholder/debug code. Hardcoded strings like 'Anxiété, Accablement, Contrariété, Jalousie,' should be replaced with dynamic data or at minimum moved to constants.

Suggested change

{[0, 1, 2, 3].map((item) => (

<View className="flex-1 flex-row items-center mb-2">

<View className="h-3 w-3 rounded-full mr-2 bg-red"></View>

<View>

<Text>Anxiété, Irritabilité</Text>

</View>

{patientStateRecordKeys.map((key) => {

let patientStateRecord = patientState[key];

if (!patientStateRecord || patientStateRecord?.value === null || patientStateRecord.value === undefined) {

return null;

}

const indicator = indicateurs.find((i) => i.genericUuid === key) || indicateurs.find((i) => i.uuid === key);

return (

<View key={key} className="flex-1 flex-row items-center mb-2">

<View className="h-3 w-3 rounded-full mr-2 bg-red"></View>

<View>

<Text>{indicator?.name || 'Unknown Indicator'}</Text>

</View>

revu-bot · 2025-09-08T16:03:25Z

app/src/scenes/status/NewStatusItem.tsx

+            />
+          )}
+          <View className="ml-2 p-2 flex-1">
+            <Text className={mergeClassNames(typography.textSmMedium, "text-cnam-primary-950")}>Anxiété, Accablement, Contrariété, Jalousie,</Text>


Hardcoded placeholder text should be replaced with dynamic data based on the actual patient state indicators.

Suggested change

<Text className={mergeClassNames(typography.textSmMedium, "text-cnam-primary-950")}>Anxiété, Accablement, Contrariété, Jalousie,</Text>

<Text className={mergeClassNames(typography.textSmMedium, "text-cnam-primary-950")}>

{patientStateRecordKeys.map(key => {

const indicator = indicateurs.find(i => i.genericUuid === key) || indicateurs.find(i => i.uuid === key);

return indicator?.name;

}).filter(Boolean).join(', ')}

</Text>

revu-bot · 2025-09-08T16:03:27Z

app/src/scenes/status/NewStatusItem.tsx

+  const hasAnswerSurvey = () =>
+    patientStateRecordKeys.some((key) => patientState[key]?.value !== undefined) || goalsData?.records?.byDate?.[date]?.length > 0;


This function calls hasAnswerSurvey() before patientStateRecordKeys is defined, which will cause a ReferenceError. The function definition should be moved after the patientStateRecordKeys declaration.

Suggested change

const hasAnswerSurvey = () =>

patientStateRecordKeys.some((key) => patientState[key]?.value !== undefined) || goalsData?.records?.byDate?.[date]?.length > 0;

// hasAnswerSurvey function moved after patientStateRecordKeys definition

revu-bot · 2025-09-08T16:03:28Z

app/src/scenes/status/NewStatusItem.tsx

+        })
+    : [];


Add the hasAnswerSurvey function definition after patientStateRecordKeys is available, and fix the logic to handle the case when patientStateRecordKeys is empty.

Suggested change

})

: [];

})

: [];

const hasAnswerSurvey = () =>

patientStateRecordKeys.some((key) => patientState[key]?.value !== undefined) || goalsData?.records?.byDate?.[date]?.length > 0;

revu-bot · 2025-09-08T16:03:29Z

app/src/scenes/status/NewStatusItem.tsx

+  let mounted = useRef(true);
+
+  useEffect(() => {
+    (async () => {
+      const c = await localStorage.getCustomSymptoms();
+      if (c && mounted) setCustoms(c);
+
+      //retrocompatibility
+      const t = c.map((e) => `${e}_FREQUENCE`);
+      if (t && mounted) setOldCustoms(t);
+      return;
+    })();
+    return () => (mounted = false);
+  }, [patientState]);


The mounted ref pattern is being used but the cleanup in useEffect return is not properly implemented. The ref should be properly typed and the cleanup should set mounted.current = false.

Suggested change

let mounted = useRef(true);

useEffect(() => {

(async () => {

const c = await localStorage.getCustomSymptoms();

if (c && mounted) setCustoms(c);

//retrocompatibility

const t = c.map((e) => `${e}_FREQUENCE`);

if (t && mounted) setOldCustoms(t);

return;

})();

return () => (mounted = false);

}, [patientState]);

const mounted = useRef(true);

revu-bot · 2025-09-08T16:03:31Z

app/src/scenes/status/NewStatusItem.tsx

+            </View>
+            {/* <View>
+            {patientStateRecordKeys.map((key) => {
+              let patientStateRecord = patientState[key];


Remove the large blocks of commented-out code. This appears to be old implementation that should either be deleted or moved to a separate branch/PR if it's still needed for reference.

revu-bot

This PR introduces a new status item design with modern styling. While the overall structure is good, there are several critical issues that need attention: a logic error in date display, dead code that should be removed, and potential rendering issues from removing the noData check. The TypeScript migration is incomplete, and there are some architectural concerns with the large component size.

revu-bot · 2025-09-09T14:16:45Z

app/src/scenes/status/DiaryList.js

-            ) : (
-              <TouchableOpacity style={styles.item} onPress={() => navigation.navigate("too-late", { date })}>
+        <View className="bg-red">
+          {!canEdit(date) && (


This condition appears to be inverted. Currently, the date container is only shown when canEdit(date) returns false, which seems backward. The date should typically be shown for all entries, or only for editable ones.

Suggested change

{!canEdit(date) && (

{canEdit(date) && (

revu-bot · 2025-09-09T14:16:47Z

app/src/scenes/status/NewStatusItem.tsx

+};
+
+const newItemCard = ({ emotionValue, handlePressItem }: { emotionValue: number; handlePressItem: any }) => {
+  <TouchableOpacity className="rounded-2xl border border-gray-500 flex-col my-4 p-6" onPress={() => handlePressItem({ editingSurvey: true })}>


This function is defined but never used, creating dead code. It should be removed to keep the codebase clean.

revu-bot · 2025-09-09T14:16:48Z

app/src/scenes/status/index.tsx

-          {noData() ? (
-            <NoData navigation={navigation} />
-          ) : ongletActif === "all" && !bannerProNPSVisible ? (
+          {ongletActif === "all" && !bannerProNPSVisible ? (


Removing the noData() check could cause the DiaryList to render even when there's no data, potentially leading to empty states or unexpected behavior. Consider adding appropriate empty state handling.

Suggested change

{ongletActif === "all" && !bannerProNPSVisible ? (

{!noData() && ongletActif === "all" && !bannerProNPSVisible ? (

revu-bot · 2025-09-09T14:16:49Z

app/src/scenes/status/NewStatusItem.tsx

+          <View style={styles.buttonsContainer}>
+            <Button icon="pencil" visible={true} onPress={() => handlePressItem({ editingSurvey: true })} />
+          </View>
+        ) : null} */}


Large commented code blocks should be removed rather than left in the codebase. This improves readability and reduces maintenance overhead.

revu-bot · 2025-09-09T14:16:51Z

app/src/scenes/status/NewStatusItem.tsx

+              title={canEdit(date) ? "Renseigner mon état pour ce jour-là" : "Je ne peux plus saisir mon questionnaire pour ce jour"}
+              image={{ source: require("./../../../assets/imgs/indicateur.png") }}
+              onPress={handlePressItem}
+            />


Another large commented code block should be removed to keep the codebase clean.

revu-bot · 2025-09-09T14:16:52Z

app/src/scenes/status/DiaryList.js

-              <Text style={styles.dateLabel}>{formatDateThread(date)}</Text>
-            ) : (
-              <TouchableOpacity style={styles.item} onPress={() => navigation.navigate("too-late", { date })}>
+        <View className="bg-red">


This debug className 'bg-red' should be removed before production deployment.

Suggested change

<View className="bg-red">

<View>

sonarqubecloud · 2025-09-11T16:00:04Z

Quality Gate failed

Failed conditions
19.5% Duplication on New Code (required ≤ 15%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

feat(status-item): integrate new status-item design

d53f1fe

revu-bot bot requested a review from revu-bot September 8, 2025 16:02

LucasCharrier marked this pull request as draft September 8, 2025 16:02

revu-bot reviewed Sep 8, 2025

View reviewed changes

chore: home statu item make a blend of old design and new design

0caec0e

LucasCharrier had a problem deploying to build-review September 9, 2025 10:29 — with GitHub Actions Error

LucasCharrier requested a review from rap2hpoutre September 9, 2025 14:15

LucasCharrier marked this pull request as ready for review September 9, 2025 14:15

revu-bot reviewed Sep 9, 2025

View reviewed changes

chore: display date only for non editable without date days

a961254

LucasCharrier had a problem deploying to build-review September 11, 2025 15:42 — with GitHub Actions Error

Merge branch 'master' into task/new-status-item

59240cb

LucasCharrier had a problem deploying to build-review September 11, 2025 15:46 — with GitHub Actions Error

chore: use squircle

a5b1a43

LucasCharrier requested a deployment to build-review September 11, 2025 15:59 — with GitHub Actions Waiting

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(status-item): integrate new status-item design #444

feat(status-item): integrate new status-item design #444

Uh oh!

LucasCharrier commented Sep 8, 2025 •

edited

Loading

Uh oh!

revu-bot left a comment

Uh oh!

revu-bot Sep 8, 2025

Uh oh!

revu-bot Sep 8, 2025

Uh oh!

revu-bot Sep 8, 2025

Uh oh!

revu-bot Sep 8, 2025

Uh oh!

revu-bot Sep 8, 2025 •

edited

Loading

Uh oh!

revu-bot Sep 8, 2025

Uh oh!

revu-bot left a comment

Uh oh!

revu-bot Sep 9, 2025

Uh oh!

revu-bot Sep 9, 2025

Uh oh!

revu-bot Sep 9, 2025

Uh oh!

revu-bot Sep 9, 2025

Uh oh!

revu-bot Sep 9, 2025

Uh oh!

revu-bot Sep 9, 2025

Uh oh!

sonarqubecloud bot commented Sep 11, 2025

Uh oh!

Uh oh!

-            <Text className={mergeClassNames(typography.textSmMedium, "text-cnam-primary-950")}>Anxiété, Accablement, Contrariété, Jalousie,</Text>
+            <Text className={mergeClassNames(typography.textSmMedium, "text-cnam-primary-950")}>
+              {patientStateRecordKeys.map(key => {
+                const indicator = indicateurs.find(i => i.genericUuid === key) || indicateurs.find(i => i.uuid === key);
+                return indicator?.name;
+              }).filter(Boolean).join(', ')}
+            </Text>

		const hasAnswerSurvey = () =>
		patientStateRecordKeys.some((key) => patientState[key]?.value !== undefined) \|\| goalsData?.records?.byDate?.[date]?.length > 0;

	const hasAnswerSurvey = () =>
	patientStateRecordKeys.some((key) => patientState[key]?.value !== undefined) \|\| goalsData?.records?.byDate?.[date]?.length > 0;
	// hasAnswerSurvey function moved after patientStateRecordKeys definition

	{ongletActif === "all" && !bannerProNPSVisible ? (
	{!noData() && ongletActif === "all" && !bannerProNPSVisible ? (

feat(status-item): integrate new status-item design #444

Are you sure you want to change the base?

feat(status-item): integrate new status-item design #444

Uh oh!

Conversation

LucasCharrier commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

revu-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

revu-bot Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

revu-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Sep 11, 2025

Quality Gate failed

Uh oh!

Uh oh!

LucasCharrier commented Sep 8, 2025 •

edited

Loading

revu-bot Sep 8, 2025 •

edited

Loading