Skip to content

Commit c6f2bab

Browse files
Remove custom JSON dumpoing wit aiohttp - should use python's default
1 parent 08c1448 commit c6f2bab

File tree

1 file changed

+10
-24
lines changed

1 file changed

+10
-24
lines changed

pyctuator/impl/aiohttp_pyctuator.py

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -21,31 +21,27 @@ class AioHttpPyctuator(PyctuatorRouter):
2121
def __init__(self, app: web.Application, pyctuator_impl: PyctuatorImpl, disabled_endpoints: Endpoints) -> None:
2222
super().__init__(app, pyctuator_impl)
2323

24-
custom_dumps = partial(
25-
json.dumps, default=self._custom_json_serializer
26-
)
27-
2824
async def empty_handler(request: web.Request) -> web.Response:
2925
return web.Response(text='')
3026

3127
async def get_endpoints(request: web.Request) -> web.Response:
32-
return web.json_response(self.get_endpoints_data(), dumps=custom_dumps)
28+
return web.json_response(self.get_endpoints_data)
3329

3430
async def get_environment(request: web.Request) -> web.Response:
35-
return web.json_response(pyctuator_impl.get_environment(), dumps=custom_dumps)
31+
return web.json_response(pyctuator_impl.get_environment)
3632

3733
async def get_info(request: web.Request) -> web.Response:
38-
return web.json_response(pyctuator_impl.get_app_info(), dumps=custom_dumps)
34+
return web.json_response(pyctuator_impl.get_app_info)
3935

4036
async def get_health(request: web.Request) -> web.Response:
4137
health = pyctuator_impl.get_health()
42-
return web.json_response(health, status=health.http_status(), dumps=custom_dumps)
38+
return web.json_response(health, status=health.http_status)
4339

4440
async def get_metric_names(request: web.Request) -> web.Response:
45-
return web.json_response(pyctuator_impl.get_metric_names(), dumps=custom_dumps)
41+
return web.json_response(pyctuator_impl.get_metric_names)
4642

4743
async def get_loggers(request: web.Request) -> web.Response:
48-
return web.json_response(pyctuator_impl.logging.get_loggers(), dumps=custom_dumps)
44+
return web.json_response(pyctuator_impl.logging.get_loggers)
4945

5046
async def set_logger_level(request: web.Request) -> web.Response:
5147
request_dict = await request.json()
@@ -57,19 +53,17 @@ async def set_logger_level(request: web.Request) -> web.Response:
5753

5854
async def get_logger(request: web.Request) -> web.Response:
5955
logger_name = request.match_info["logger_name"]
60-
return web.json_response(pyctuator_impl.logging.get_logger(logger_name), dumps=custom_dumps)
56+
return web.json_response(pyctuator_impl.logging.get_logger(logger_name))
6157

6258
async def get_thread_dump(request: web.Request) -> web.Response:
63-
return web.json_response(pyctuator_impl.get_thread_dump(), dumps=custom_dumps)
59+
return web.json_response(pyctuator_impl.get_thread_dump)
6460

6561
async def get_httptrace(request: web.Request) -> web.Response:
6662
raw_data = pyctuator_impl.http_tracer.get_httptrace()
67-
return web.json_response(raw_data, dumps=custom_dumps)
63+
return web.json_response(raw_data)
6864

6965
async def get_metric_measurement(request: web.Request) -> web.Response:
70-
return web.json_response(
71-
pyctuator_impl.get_metric_measurement(request.match_info["metric_name"]),
72-
dumps=custom_dumps)
66+
return web.json_response( pyctuator_impl.get_metric_measurement(request.match_info["metric_name"]))
7367

7468
async def get_logfile(request: web.Request) -> web.Response:
7569
range_header = request.headers.get("range")
@@ -153,14 +147,6 @@ async def intercept_requests_and_responses(request: web.Request, handler: Callab
153147
app.add_routes(routes)
154148
app.middlewares.append(intercept_requests_and_responses)
155149

156-
def _custom_json_serializer(self, value: Any) -> Any:
157-
if dataclasses.is_dataclass(value):
158-
return dataclasses.asdict(value)
159-
160-
if isinstance(value, datetime):
161-
return str(value)
162-
return None
163-
164150
def _create_headers_dictionary(self, headers: CIMultiDictProxy[str]) -> Mapping[str, List[str]]:
165151
headers_dict: Mapping[str, List[str]] = defaultdict(list)
166152
for (key, value) in headers.items():

0 commit comments

Comments
 (0)