Skip to content

Commit e3d7215

Browse files
committed
chore: translate comments
1 parent 8606eb9 commit e3d7215

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

CodePush.js

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -99,26 +99,29 @@ async function checkForUpdate(handleBinaryVersionMismatchCallback = null) {
9999
is_available: latestReleaseInfo.enabled,
100100
package_hash: latestReleaseInfo.packageHash,
101101
is_mandatory: isMandatory,
102-
// 이건 항상 현재 실행중인 바이너리 버전을 전달한다.
103-
// 조회한 업데이트가 현재 바이너리를 타겟하는가? 를 API 서버에서 판단한 다음, 해당 된다면 런타임 바이너리 버전을 그대로 돌려주던 것임.
104-
// 우리는 updateChecker 조회 결과가 넘어왔다면 해당 정보는 현재 런타임 바이너리에 호환됨을 전제로 하고있음.
102+
/**
103+
* The `ReleaseHistoryInterface` data returned by the `releaseHistoryFetcher` function is
104+
* based on the assumption that it is compatible with the current runtime binary.
105+
* (because it is querying the update history deployed for the current binary version)
106+
* Therefore, the current runtime binary version should be passed as it is.
107+
*/
105108
target_binary_range: updateRequest.app_version,
106109
/**
107110
* Retrieve the update version from the ReleaseHistory and store it in the label.
108111
* This information can be accessed at runtime through the CodePush bundle metadata.
109112
*/
110113
label: latestVersion,
111-
// false 전달해야 정상 동작함
114+
// `false` should be passed to work properly
112115
update_app_version: false,
113-
// 그닥 쓸모 없음
114-
description: '',
115-
// 런타임에 안쓰임
116+
// currently not used.
117+
description: "",
118+
// not used at runtime.
116119
is_disabled: false,
117-
// 런타임에 안쓰임
120+
// not used at runtime.
118121
package_size: 0,
119-
// 런타임에 안쓰임
122+
// not used at runtime.
120123
should_run_binary_version: false,
121-
}
124+
};
122125

123126
return mapToRemotePackageMetadata(updateInfo);
124127
}

0 commit comments

Comments
 (0)