feat(expo): Add Expo config plugin for automated CodePush setup #74

saseungmin · 2025-06-11T06:46:23Z

📝 Overview

This PR adds an Expo config plugin that automatically configures CodePush for Expo projects, eliminating the need for manual native code modifications. The plugin handles both iOS and Android platform setup through Expo's prebuild process.

Related issue: [Feature Request] Add Expo support for CodePush #72

✨ What's Added

Expo Config Plugin: Automated CodePush integration for Expo projects
Handles both iOS and Android native code modifications
Comprehensive warnings for unsupported configurations
Zero Manual Setup
Documentation Updates (README.md)
- Added Expo plugin setup guide to installation section

🎯 Usage

Installation

npm install @bravemobile/react-native-code-push

Configuration

Add the plugin to your Expo config:

app.config.js:

export default {
  expo: {
    plugins: ["@bravemobile/react-native-code-push"],
  },
};

Build Process

# Prebuild to apply native changes
npx expo prebuild

🚨 Error Handling

The plugin includes comprehensive warning systems:

Unsupported file formats: Clear guidance for manual setup
Missing files: Helpful error messages with setup instructions
Template variations: Warnings for non-standard Expo templates

✅ Platform Support

Android

Kotlin MainApplication (Expo default)
Automatic gradle script integration
CodePush import and method implementation

iOS

Swift AppDelegate with bridging header
Objective-C AppDelegate
Automatic CodePush import and bundle URL override

✅ Testing

Tested with Expo SDK 52, 53 projects
Verified both iOS and Android configurations
Confirmed compatibility with default Expo templates
Validated error handling for edge cases

🔄 Breaking Changes

None - This is an additive feature that doesn't affect existing functionality.

floydkim

Great work.
Thanks for your contribution and the detailed description.

I’ve added a few comments.
feel free to check them out and let me know what you think.

floydkim · 2025-06-18T14:25:09Z

package.json

+  "peerDependenciesMeta": {
+    "expo": {
+      "optional": true
+    }
+  },


floydkim · 2025-06-18T15:13:58Z

expo/plugin/withCodePush.js

+const { createRunOncePlugin } = require('expo/config-plugins');
+const { withAndroidBuildScriptDependency, withAndroidMainApplicationDependency } = require('./withCodePushAndroid');
+const { withIosBridgingHeader, withIosAppDelegateDependency } = require('./withCodePushIos');
+const pkg = require('../../package.json');


Does it intend to refer to the @bravemobile/react-native-code-push package?
Just curious.

floydkim · 2025-06-18T15:23:36Z

expo/plugin/withCodePushAndroid.js

+    action.modResults.contents = androidMainApplicationApplyImplementation(
+      action.modResults.contents,
+      'class MainApplication : Application(), ReactApplication {',
+      'import com.microsoft.codepush.react.CodePush\n',
+      true,
+    );
+
+    action.modResults.contents = androidMainApplicationApplyImplementation(
+      action.modResults.contents,
+      'object : DefaultReactNativeHost(this) {',
+      '          override fun getJSBundleFile(): String = CodePush.getJSBundleFile()\n',
+    );


Is the MainApplication file written in Kotlin starting from Expo SDK 50?
Is there no need to support the case where it is written in Java?

floydkim · 2025-06-18T15:27:55Z

README.md

@@ -35,7 +35,30 @@ The following changes are optional but recommended for cleaning up the old confi
 npm install @bravemobile/react-native-code-push
 ```

-### 2. iOS Setup
+### 2. Expo Setup


Sorry, but since our team, as maintainers, doesn’t use Expo in our environment, supporting Expo has a lower priority compared to RN CLI projects.
Although Expo is recommended, our library still prioritizes RN CLI support.

so, please move the Expo setup instructions to come after the iOS/Android sections. 🙏

floydkim · 2025-06-18T15:29:44Z

README.md

+npx expo prebuild
+```
+
+>[!NOTE] The plugin automatically handles all native iOS and Android code modifications. No manual editing of AppDelegate, MainApplication, or gradle files is required.


Suggested change

>[!NOTE] The plugin automatically handles all native iOS and Android code modifications. No manual editing of AppDelegate, MainApplication, or gradle files is required.

> [!NOTE]

> The plugin automatically handles all native iOS and Android code modifications. No manual editing of AppDelegate, MainApplication, or gradle files is required.

Note
The plugin automatically handles all native iOS and Android code modifications. No manual editing of AppDelegate, MainApplication, or gradle files is required.

floydkim · 2025-06-18T15:36:45Z

expo/plugin/withCodePushIos.js

+        'withIosBridgingHeader',
+        `
+        Failed to detect ${bridgingHeaderFilePath} file.
+        Please add CodePush integration manually:
+        #import <CodePush/CodePush.h>
+
+        Supported format: Expo SDK default template.
+        `


It might be a good idea to add a reference link here as well.

e.g.
https://github.com/Soomgo-Mobile/react-native-code-push#2-edit-appdelegate-code

floydkim · 2025-06-18T15:44:30Z

package-lock.json

floydkim · 2025-06-18T15:48:34Z

expo/plugin/withCodePushIos.js

+      action.modResults.contents = iosApplyImplementation(
+        action.modResults.contents,
+        `return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];`,
+        `return [CodePush bundleURL];`,
+        true,
+      );


I was just wondering..
Expo plugins probably don’t modify and commit changes to AppDelegate/MainApplication file.

If so, the code developers see might be different from what’s actually used at build time.
I think this could be confusing. Especially if someone tries to search the code.
And if someone modified the code, this plugin might not work correctly.

This plugin is great!
but from a maintenance perspective, I personally think it’s better for developers to update and manage their code manually.

No worries, this PR won't be rejected :)

floydkim · 2025-06-18T15:54:28Z

expo/plugin/withCodePushIos.js

+      const bridgingHeaderPath = config.buildSettings[
+        'SWIFT_OBJC_BRIDGING_HEADER'
+      ].replace(/"/g, '');


I suspect that value of bridgingHeaderPath is a file name, not a path 🤔
I think it would be better to rename to bridgingHeaderFile.

saseungmin added 3 commits June 11, 2025 13:27

feat: set up and implement Expo plugin for code push

93c1091

docs: add Expo plugin setup guide to installation section

38fd518

chore: fix error console manual setup link

6747661

This was referenced Jun 11, 2025

feat(cli): add expo framework support to bundle command #73

Open

[Feature Request] Add Expo support for CodePush #72

Open

floydkim self-requested a review June 14, 2025 13:50

floydkim reviewed Jun 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(expo): Add Expo config plugin for automated CodePush setup #74

feat(expo): Add Expo config plugin for automated CodePush setup #74

Uh oh!

saseungmin commented Jun 11, 2025 •

edited

Loading

Uh oh!

floydkim left a comment

Uh oh!

floydkim Jun 18, 2025

Uh oh!

floydkim Jun 18, 2025

Uh oh!

floydkim Jun 18, 2025

Uh oh!

floydkim Jun 18, 2025

Uh oh!

floydkim Jun 18, 2025

Uh oh!

floydkim Jun 18, 2025

Uh oh!

floydkim Jun 18, 2025

Uh oh!

floydkim Jun 18, 2025

Uh oh!

floydkim Jun 18, 2025

Uh oh!

Uh oh!

	>[!NOTE] The plugin automatically handles all native iOS and Android code modifications. No manual editing of AppDelegate, MainApplication, or gradle files is required.
	> [!NOTE]
	> The plugin automatically handles all native iOS and Android code modifications. No manual editing of AppDelegate, MainApplication, or gradle files is required.

feat(expo): Add Expo config plugin for automated CodePush setup #74

Are you sure you want to change the base?

feat(expo): Add Expo config plugin for automated CodePush setup #74

Uh oh!

Conversation

saseungmin commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Overview

✨ What's Added

🎯 Usage

Installation

Configuration

Build Process

🚨 Error Handling

✅ Platform Support

Android

iOS

✅ Testing

🔄 Breaking Changes

Uh oh!

floydkim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

saseungmin commented Jun 11, 2025 •

edited

Loading