-
Notifications
You must be signed in to change notification settings - Fork 8
Add launch file for zed-ros2-wrapper
#102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
onkoe
wants to merge
12
commits into
Sooner-Rover-Team:main
Choose a base branch
from
onkoe:feat/zed_official_pkg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
540fadc
to
c500a64
Compare
otherwise, we get two tf trees that aren't related, which causes nodes to be veeeery confused D:
we can't keep that unportable stuff in our repo... but we can use an edited version of its parameters file here. doing so keeps our configuration consistent and clean
we do this to avoid nonsense related to the real launch file (i.e. from the wrapper). it might be overwritten or lost depending on what we end up doin so having this is much safer. i also added some typing changes + fixes
which is more accurate. i expect to get better testing results w/ this
to reduce processing requirements + increase accuracy
we shouldn't be using this for long into the future. i added it for now, though.
8619a21
to
d190d02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
configuration
related to parameters and node configuration
object avoidance
src/navigator
Has to do w/ the `navigator` package + `navigator_node`
src/sensors
Has to do w/ the `sensors` package
test on rover before review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be fully-configured. Just needs to be tested on the Rover.
If it works too well, might be getting a tattoo...
Changes
TODO.
Checklist
zed-ros2-wrapper
node onto the Roverdrive_launcher
tosimulator