Skip to content

Location: Make lat/lon optional, but add more validation logic #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Location: Make lat/lon optional, but add more validation logic #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions 15-draft.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,15 @@
"minItems": 1
}
},
"required": [
"lat",
"lon"
]
"minProperties": 1,
"dependentRequired": {
"lat": [
"lon"
],
"lon": [
"lat"
]
}
},
"spacefed": {
"description": "A flag indicating if the hackerspace uses SpaceFED, a federated login scheme so that visiting hackers can use the space WiFi with their home space credentials.",
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ Root level:
- [added] The `areas` field was added ([#107])
- [added] The `hint` field was added ([#102])
- [changed] Make entire `location` field optional to enable the inclusion of groups without physical location ([#106])
- [changed] If the `location` field is present, it requires at least 1 property ([#115])
- [changed] Make the `lat`/`lon` fields optional, but if one of them is provided, then the other one must be provided too ([#115])

`sensors`:

Expand Down Expand Up @@ -115,3 +117,4 @@ Root level:
[#106]: https://github.com/SpaceApi/schema/pull/106
[#108]: https://github.com/SpaceApi/schema/pull/108
[#107]: https://github.com/SpaceApi/schema/pull/107
[#115]: https://github.com/SpaceApi/schema/pull/115