Add particulate_matter sensor type
#131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
reviewed
Oct 5, 2025
Comment on lines
+1342
to
+1343
| "PM4.25": { | ||
| "description": "Concentration of particulate matter with a diameter of 4.25µm or less.", |
There was a problem hiding this comment.
Suggested change
| "PM4.25": { | |
| "description": "Concentration of particulate matter with a diameter of 4.25µm or less.", | |
| "PM4": { | |
| "description": "Concentration of particulate matter with a diameter of 4µm or less.", |
There was a problem hiding this comment.
I did some online research and found that "PM4.25" seems to be an industry standard. Are you sure "PM4" isn't just an abbreviation used by your sensor?
There was a problem hiding this comment.
The actual question would be if statically defined PM sizes are adequate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
particulate_mattersensor type as proposed in #129.@mweinelt I would also ask you to provide feedback as well since you requested this feature in the first place.