Skip to content

Missing Bindings / Incorrect return types #290

@baileysostek

Description

@baileysostek

Version

1.87.5

What part of the binding has gaps?

ImNodes

What is missing?

Something is missing! I think the return types of all of these getters are supposed to be numeric instead of void. I am not sure if the value is returned in subpixel floating point or pixel based integer, but if i had to guess the positions are represented as integers.

Here is the code that I think needs to change to return integer instead of void:
imgui-java/imgui-binding/src/generated/java/imgui/extension/imnodes /ImNodes.java

Lines 555 - 577

public static void getNodeScreenSpacePos(final int nodeId) {
    nGetNodeScreenSpacePos(nodeId);
}

private static native void nGetNodeScreenSpacePos(int nodeId); /*
    ImNodes::GetNodeScreenSpacePos(nodeId);
*/

public static void getNodeEditorSpacePos(final int nodeId) {
    nGetNodeEditorSpacePos(nodeId);
}

private static native void nGetNodeEditorSpacePos(int nodeId); /*
    ImNodes::GetNodeEditorSpacePos(nodeId);
*/

public static void getNodeGridSpacePos(final int nodeId) {
    nGetNodeGridSpacePos(nodeId);
}

private static native void nGetNodeGridSpacePos(int nodeId); /*
    ImNodes::GetNodeGridSpacePos(nodeId);
*/

Metadata

Metadata

Assignees

No one assigned

    Labels

    missing bindingSome of the original library API is missing

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions