Skip to content

Add support for Azure workload identity #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for Azure workload identity #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cmd/azure-keyvault-env/authentication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,19 @@ func getCredentials() (azure.LegacyTokenCredential, string, error) {
return creds, provider.GetAzureKeyVaultDNSSuffix(), nil
}

func getCredentialsIdentity() (azure.LegacyTokenCredential, string, error) {
provider, err := credentialprovider.NewFromAzidentity()
if err != nil {
return nil, "", fmt.Errorf("failed to create credentials provider for azure key vault, error: %w", err)
}

creds, err := provider.GetAzureKeyVaultCredentials()
if err != nil {
return nil, "", fmt.Errorf("failed to get credentials for azure key vault, error: %w", err)
}
return creds, provider.GetAzureKeyVaultDNSSuffix(), nil
}

func getCredentialsAuthService(authServiceAddress string, authServiceValidationAddress string, clientCertDir string) (azure.LegacyTokenCredential, error) {
startupCACert, err := os.ReadFile(path.Join(clientCertDir, "ca.crt"))
if err != nil {
Expand Down
18 changes: 14 additions & 4 deletions cmd/azure-keyvault-env/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ type injectorConfig struct {
retryTimes int
waitTimeBetweenRetries int
useAuthService bool
useWorkloadIdentity bool
skipArgsValidation bool
authServiceAddress string
authServiceValidationAddress string
Expand Down Expand Up @@ -126,6 +127,7 @@ func initConfig() {
viper.SetDefault("env_injector_retries", 3)
viper.SetDefault("env_injector_wait_before_retry", 3)
viper.SetDefault("env_injector_use_auth_service", true)
viper.SetDefault("env_injector_use_workload_identity", false)

viper.SetDefault("env_injector_skip_args_validation", false)
viper.SetDefault("env_injector_log_level", "info")
Expand Down Expand Up @@ -185,9 +187,10 @@ func main() {

config = injectorConfig{
// required
signatureB64: viper.GetString("env_injector_args_signature"),
pubKeyBase64: viper.GetString("env_injector_args_key"),
useAuthService: viper.GetBool("env_injector_use_auth_service"),
signatureB64: viper.GetString("env_injector_args_signature"),
pubKeyBase64: viper.GetString("env_injector_args_key"),
useAuthService: viper.GetBool("env_injector_use_auth_service"),
useWorkloadIdentity: viper.GetBool("env_injector_use_workload_identity"),

// required if auth service
clientCertDir: viper.GetString("env_injector_client_cert_dir"),
Expand Down Expand Up @@ -255,7 +258,14 @@ func main() {

var creds azure.LegacyTokenCredential
var keyVaultDNSSuffix string
if config.useAuthService {
if config.useWorkloadIdentity {
creds, keyVaultDNSSuffix, err = getCredentialsIdentity()
if err != nil {
klog.ErrorS(err, "failed to get credentials", "failedTimes", config.retryTimes)
os.Exit(1)
}
}
else if config.useAuthService {
provider, err := credentialprovider.NewFromEnvironment()
if err != nil {
klog.ErrorS(err, "failed to get provider from environment", "failedTimes", config.retryTimes)
Expand Down