Skip to content

fix: resize observer to detect child changes #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: resize observer to detect child changes #22

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
93a1905
resize observer for children
dword-design Aug 13, 2024
41daa62
remove unneeded variable
dword-design Aug 13, 2024
3f762e0
fixes
dword-design Aug 13, 2024
195cf65
detect container resize
dword-design Nov 17, 2024
d16fcb6
fix: fix
dword-design Nov 17, 2024
ece532c
destroy -> disconnect
dword-design Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 29 additions & 18 deletions src/minimasonry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
var MiniMasonry = function(conf) {
this._sizes = [];
this._columns = [];
this._container = null;
this._count = null;
this._width = 0;
this._removeListener = null;
this._currentGutterX = null;
this._currentGutterY = null;
this._sizes = [];
this._columns = [];
this._container = null;
this._count = null;
this._width = 0;
this._removeListener = null;
this._currentGutterX = null;
this._currentGutterY = null;
this._containerResizeObserver = null;
this._childrenResizeObserver = null;
this._mutationObserver = null;

this._resizeTimeout = null,

Expand Down Expand Up @@ -50,14 +53,22 @@ MiniMasonry.prototype.init = function(conf) {
}

var onResize = this.resizeThrottler.bind(this)
window.addEventListener("resize", onResize);
this._removeListener = function() {
window.removeEventListener("resize", onResize);
if (this._resizeTimeout != null) {
window.clearTimeout(this._resizeTimeout);
this._resizeTimeout = null;

this._containerResizeObserver = new ResizeObserver(onResize);

this._childrenResizeObserver = new ResizeObserver(() => this.layout());

this._mutationObserver = new MutationObserver(() => {

this._childrenResizeObserver.disconnect();

for (const child of this._container.children) {
this._childrenResizeObserver.observe(child);
}
}
});

this._containerResizeObserver.observe(this._container);
this._mutationObserver.observe(this._container, { childList: true });

this.layout();
};
Expand Down Expand Up @@ -223,9 +234,9 @@ MiniMasonry.prototype.resizeThrottler = function() {
}

MiniMasonry.prototype.destroy = function() {
if (typeof this._removeListener == "function") {
this._removeListener();
}
this._containerResizeObserver.disconnect();
this._childrenResizeObserver.disconnect();
this._mutationObserver.disconnect();

var children = this._container.children;
for (var k = 0;k< children.length; k++) {
Expand Down