Skip to content

Add missing figures#23

Merged
Ducasse merged 2 commits intoSquareBracketAssociates:masterfrom
guillep:fix-mutalk
Apr 28, 2026
Merged

Add missing figures#23
Ducasse merged 2 commits intoSquareBracketAssociates:masterfrom
guillep:fix-mutalk

Conversation

@guillep
Copy link
Copy Markdown
Collaborator

@guillep guillep commented Mar 23, 2026

Try fixing the mutalk chapter

I managed to build it in my machine with these missing files doing:

pillar build pdf Chapters/Mutalk/Mutalk.md
pillar build pdf index.md

Looks however that there are some broken refs

warning  (pdf backend): unreferenced destination with name 'Evaluation-of-mutan
ts'

warning  (pdf backend): unreferenced destination with name 'Mutant-generation'

warning  (pdf backend): unreferenced destination with name 'Coverage-analysis'

warning  (pdf backend): unreferenced destination with name 'Initial-test-run'

@Ducasse
Copy link
Copy Markdown
Member

Ducasse commented Mar 23, 2026

I will apply also some checkers on the book to see if they work. But I will do that with the special version of pharo. Just pushing some changes if I find some 'bugs.'

@AndrzejProchyra
Copy link
Copy Markdown
Contributor

AndrzejProchyra commented Apr 4, 2026

@guillep It seems that to build using the workflow we still need to fix the reference to the MuTalk chapter in index.md

<!inputFile|path=Chapters/Mutalk/Mutalk.md!>

becomes

<!inputFile|path=Chapters/MuTalk/MuTalk.md!>.

Additionally, there are still 2 missing figures:

  • Chapters/MuTalk/figures/MyVehicleHeatmapCropped.pdf
  • Chapters/MuTalk/figures/MyVehicleMatrixCropped.pdf

I have updated the reference, added placeholder figures and built it here: https://github.com/AndrzejProchyra/Booklet-TestingInPharo/actions/runs/23980986011.

Presumably the figures can be regenerated. I haven't read the chapter yet 🙂.

@Ducasse
Copy link
Copy Markdown
Member

Ducasse commented Apr 4, 2026

Thanks. I should run the new checker on it :) and also fix the checker :)

@Ducasse Ducasse merged commit 8621663 into SquareBracketAssociates:master Apr 28, 2026
@guillep guillep deleted the fix-mutalk branch April 28, 2026 07:34
@guillep
Copy link
Copy Markdown
Collaborator Author

guillep commented Apr 28, 2026

Hi @AndrzejProchyra ! Should we do a pull request with your other changes? I assume you're a in a case sensitive file system? :) Because I manage to build on MacOS xD

@AndrzejProchyra
Copy link
Copy Markdown
Contributor

Hi @guillep! I opened #25 to do this 🙂.

I also use macOS, but haven't been able to set up a working build locally. I was seeing the failures in the GitHub Actions workflow in this repository (which uses the shared workflow, so runs on Ubuntu). With this change the workflow passes and builds the PDF! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants