Add missing figures#23
Conversation
|
I will apply also some checkers on the book to see if they work. But I will do that with the special version of pharo. Just pushing some changes if I find some 'bugs.' |
|
@guillep It seems that to build using the workflow we still need to fix the reference to the MuTalk chapter in
becomes
Additionally, there are still 2 missing figures:
I have updated the reference, added placeholder figures and built it here: https://github.com/AndrzejProchyra/Booklet-TestingInPharo/actions/runs/23980986011. Presumably the figures can be regenerated. I haven't read the chapter yet 🙂. |
|
Thanks. I should run the new checker on it :) and also fix the checker :) |
|
Hi @AndrzejProchyra ! Should we do a pull request with your other changes? I assume you're a in a case sensitive file system? :) Because I manage to build on MacOS xD |
|
Hi @guillep! I opened #25 to do this 🙂. I also use macOS, but haven't been able to set up a working build locally. I was seeing the failures in the GitHub Actions workflow in this repository (which uses the shared workflow, so runs on Ubuntu). With this change the workflow passes and builds the PDF! 🥳 |
Try fixing the mutalk chapter
I managed to build it in my machine with these missing files doing:
Looks however that there are some broken refs