Anime example app initial commit #298
Conversation
There was a problem hiding this comment.
Thanks for the amazing PR @Potatomonsta 🤩
I have some suggestions please check them out!!
examples/ani_watch/README.md
Outdated
| @@ -0,0 +1,16 @@ | |||
| # AniWatch | |||
|
|
|||
| A new Flutter project. | |||
There was a problem hiding this comment.
Can we add some proper documentation?
There was a problem hiding this comment.
added some documentation here
| { | ||
| "type": "scaffold", | ||
| "body": { | ||
| "type": "stack", |
There was a problem hiding this comment.
Do we need stac widget here? Can we replace it with column?
There was a problem hiding this comment.
yeah, since the bottom panel is placed on top of the image, in the future there will also be a a carousel indicator on top of the image
There was a problem hiding this comment.
Let's remove it now. If needed, we'll add it in future.
There was a problem hiding this comment.
its needed right now too, for the image to align properly (crop vertically at bottom) since we do not have fittedBox yet.
| "width": 10000, | ||
| "height": 10000, |
There was a problem hiding this comment.
Use maxFinite instead of 10000.
| "height": 10 | ||
| }, | ||
| { | ||
| "type": "text", |
There was a problem hiding this comment.
Do we need to put text in the children? Can we use it directly in the data?
There was a problem hiding this comment.
rewrote to use copyWithStyle
| "child": { | ||
| "type": "stack", | ||
| "fit": "expand", | ||
| "children": [ | ||
| { | ||
| "type": "backdropFilter", | ||
| "filter": {"type": "blur", "sigmaX": 20.0, "sigmaY": 20.0}, | ||
| }, |
There was a problem hiding this comment.
Can we remove the stack and backdrop filter?
There was a problem hiding this comment.
pushed a fix to make it hopefully work for iOS
| sortType: AniListAPIUtils.sortTrendingDesc, | ||
| ), | ||
| // { | ||
| // "type": "sizedBox", |
There was a problem hiding this comment.
Can we remove the comments?
There was a problem hiding this comment.
These are additional sections that are temporarily commented out to reduce API calls, we might enable them later
There was a problem hiding this comment.
Let's remove it for better code readability. We can add it in future if needed.
There was a problem hiding this comment.
Can we remove the font file which are not needed?
There was a problem hiding this comment.
should we remove italics? its part of the font and we might use italics later, also could be part of anime description(not handled atm, but something to do in the future)
There was a problem hiding this comment.
Let's remove it. We can add it in future if needed.
There was a problem hiding this comment.
Can we please use the correct file name?
There was a problem hiding this comment.
done, renamed to anime_home
Potatomonsta
force-pushed
the
aniwatch
branch
2 times, most recently
from
c5cf119 to
8379aae
Compare
AniWatch example app
- Removed unused images - Minor changes to onboarding to make it more up to date with Stac changes - Renamed movie_carousel to anime_home_carousel - Episode list is not reversed on details screen now - Bottom nav height adjusted for iOS - Updated Readme.md
- removed commented code in home - removed Figtree italic files
AniWatch example app
Description
Added Anime example app AniWatch
Type of Change