Skip to content
This repository was archived by the owner on Sep 9, 2024. It is now read-only.

Commit fa99ed7

Browse files
authored
fix: properly validate all locales in mobile mode (#951)
1 parent 7a999ee commit fa99ed7

File tree

1 file changed

+13
-44
lines changed

1 file changed

+13
-44
lines changed

packages/core/src/components/entry-editor/EditorInterface.tsx

Lines changed: 13 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ const EditorInterface = ({
303303
const editorLocale = useMemo(
304304
() =>
305305
locales
306-
?.filter(l => l !== defaultLocale)
306+
?.filter(locale => isSmallScreen || locale !== defaultLocale)
307307
.map(locale => (
308308
<div
309309
key={locale}
@@ -319,9 +319,10 @@ const EditorInterface = ({
319319
fieldsErrors={fieldsErrors}
320320
locale={locale}
321321
onLocaleChange={handleLocaleChange}
322+
allowDefaultLocale={isSmallScreen}
322323
submitted={submitted}
323324
canChangeLocale
324-
context="i18nSplit"
325+
context={!isSmallScreen ? 'i18nSplit' : undefined}
325326
hideBorder
326327
t={t}
327328
/>
@@ -334,6 +335,7 @@ const EditorInterface = ({
334335
fields,
335336
fieldsErrors,
336337
handleLocaleChange,
338+
isSmallScreen,
337339
locales,
338340
selectedLocale,
339341
submitted,
@@ -347,38 +349,6 @@ const EditorInterface = ({
347349
[collectHasI18n, collection, defaultLocale, entry, selectedLocale],
348350
);
349351

350-
const mobileLocaleEditor = useMemo(
351-
() =>
352-
isSmallScreen ? (
353-
<div key={selectedLocale} className={classes['mobile-i18n']}>
354-
<EditorControlPane
355-
collection={collection}
356-
entry={entry}
357-
fields={fields}
358-
fieldsErrors={fieldsErrors}
359-
locale={selectedLocale}
360-
onLocaleChange={handleLocaleChange}
361-
allowDefaultLocale
362-
submitted={submitted}
363-
canChangeLocale
364-
hideBorder
365-
t={t}
366-
/>
367-
</div>
368-
) : null,
369-
[
370-
collection,
371-
entry,
372-
fields,
373-
fieldsErrors,
374-
handleLocaleChange,
375-
isSmallScreen,
376-
selectedLocale,
377-
submitted,
378-
t,
379-
],
380-
);
381-
382352
const editorWithPreview = (
383353
<div
384354
className={classNames(classes.root, editorSize === EDITOR_SIZE_COMPACT && classes.compact)}
@@ -396,16 +366,15 @@ const EditorInterface = ({
396366
</div>
397367
);
398368

399-
const editorSideBySideLocale = (
400-
<>
401-
<div className={classNames(classes.root, classes['wrapper-i18n-side-by-side'])}>
402-
<ScrollSyncPane>{editor}</ScrollSyncPane>
403-
<ScrollSyncPane>
404-
<>{editorLocale}</>
405-
</ScrollSyncPane>
406-
</div>
407-
{mobileLocaleEditor}
408-
</>
369+
const editorSideBySideLocale = isSmallScreen ? (
370+
<>{editorLocale}</>
371+
) : (
372+
<div className={classNames(classes.root, classes['wrapper-i18n-side-by-side'])}>
373+
<ScrollSyncPane>{editor}</ScrollSyncPane>
374+
<ScrollSyncPane>
375+
<>{editorLocale}</>
376+
</ScrollSyncPane>
377+
</div>
409378
);
410379

411380
const summary = useMemo(() => selectEntryCollectionTitle(collection, entry), [collection, entry]);

0 commit comments

Comments
 (0)