Skip to content

Commit 600961a

Browse files
committed
Fix color previews rounding all values up
1 parent 0be3341 commit 600961a

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/kv-core/kv-color.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ test("Color Matches Valid 0-255", () => {
44
const desc = getColorMatches("{0 255 10}");
55
expect(desc.validFormat).toBe(true);
66
expect(desc.r).toBe(0);
7-
expect(desc.g).toBe(255);
8-
expect(desc.b).toBe(10);
7+
expect(desc.g).toBe(1);
8+
expect(desc.b).toBeCloseTo(0.0392);
99
expect(desc.a).toBe(1);
1010
expect(desc.parenthesisType).toBe(ColorMatchParenthesisType.Braces);
1111
});
@@ -14,8 +14,8 @@ test("Color Matches Valid 0-1", () => {
1414
const desc = getColorMatches("[0 1 0.1]");
1515
expect(desc.validFormat).toBe(true);
1616
expect(desc.r).toBe(0);
17-
expect(desc.g).toBe(255);
18-
expect(desc.b).toBe(25.5);
17+
expect(desc.g).toBe(1);
18+
expect(desc.b).toBe(0.1);
1919
expect(desc.a).toBe(1);
2020
expect(desc.parenthesisType).toBe(ColorMatchParenthesisType.Brackets);
2121
});

src/kv-core/kv-color.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ export function getColorMatches(colorString: string): ColorMatchDescription {
7575
if(r > limitMax || r < limitMin || g > limitMax || g < limitMin || b > limitMax || b < limitMin) {
7676
return createOutOfBounds(parenType);
7777
}
78-
if(!is255) {
79-
r *= 255;
80-
g *= 255;
81-
b *= 255;
78+
if(is255) {
79+
r /= 255;
80+
g /= 255;
81+
b /= 255;
8282
}
8383

8484
return createValid(r, g, b, parenType);

0 commit comments

Comments
 (0)