Fix getRectForRef - current not set error #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing logs. It is valid when current is not set because of the timeout used, the component may have unmounted.
|
I'm seeing a lot of unrelated changes. Could you clean up the PR to only include the relevant changes? It looks like you're catching the error and then returning an incorrect Rect value. Could you explain how this solves the problem? Isn't the solution to this whole problem that the component needs to clear the timeout when it unmounts? In other words, the timeout needs to be stored in a React.ref which is then called through clearTimeout in a useEffect return function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #153 error filing people's logs. It is valid when current is not set because of the timeout used, the component may have unmounted.