Fix computed observable issue with KO3 #190
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Knockout 3.0.0 changes the default behaviour for computed observables to avoid notifying when the computed value hasn't changed. We rely on getting these notifications, so we need to ensure that we set the old behaviour.
|
Although the tests pass when running with KO 3.0.0, some of them are still failing with 3.1.0 or 3.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of changes, to update the target version of Knockout to 3.0.0 and to fix an issue with computed observables not notifying on change. The tests all still pass on Knockout 2.x, and now also pass on Knockout 3.0.0.