Skip to content

Fix computed observable issue with KO3 #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix computed observable issue with KO3 #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6ae915
Always explicitly notify on computed observables.
andrewaylett Feb 19, 2014
7cc7e3d
Bump the Knockout version up to 3.0.0.
andrewaylett Feb 19, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions knockout.mapping.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,14 @@
return DO(val);
},
deferEvaluation: true
});
}).extend({notify: 'always'});
if (DEBUG) wrapped._wrapper = true;
wrapped.__DO = DO;
return wrapped;
};

options.deferEvaluation = true; // will either set for just options, or both read/options.
var realDependentObservable = new realKoDependentObservable(read, owner, options);
var realDependentObservable = new realKoDependentObservable(read, owner, options).extend({notify: 'always'});

if (!realDeferEvaluation) {
realDependentObservable = wrap(realDependentObservable);
Expand Down
2 changes: 1 addition & 1 deletion spec/runner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<link rel="stylesheet" href="lib/qunit-1.10.0.css" type="text/css" media="screen">
<script type="text/javascript" src="lib/qunit-1.10.0.js"></script>
<script type="text/javascript" src="lib/json2.js"></script>
<script type="text/javascript" src="http://knockoutjs.com/downloads/knockout-2.2.0.js"></script>
<script type="text/javascript" src="http://knockoutjs.com/downloads/knockout-3.0.0.js"></script>
<script type="text/javascript" src="../knockout.mapping.js"></script>
<script type="text/javascript">
var curModuleName;
Expand Down