Skip to content

Commit aad74e9

Browse files
committed
Fixed link_errno warnings
1 parent 66fc439 commit aad74e9

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

include/api/SObject.hpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,13 @@ class SObject {
5050

5151
/*! \details Clears the current error.
5252
*/
53-
void clear_error() const { m_error_number = ERROR_NONE; }
53+
void clear_error_number() const { m_error_number = ERROR_NONE; }
5454

5555
protected:
5656

57+
//These methods are used internally to assign the error_number() value
5758
int set_error_number_if_error(int ret) const;
58-
59-
/*! \details Sets the error number.
60-
*
61-
* @param value The value to assign to the error number.
62-
*/
59+
void set_error_number_to_errno() const;
6360
void set_error_number(int value) const { m_error_number = value; }
6461

6562
private:

src/api/SObject.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,12 @@ int SObject::set_error_number_if_error(int ret) const {
3030
}
3131
return ret;
3232
}
33+
34+
void SObject::set_error_number_to_errno() const {
35+
#if defined __link
36+
set_error_number(link_errno);
37+
#else
38+
set_error_number(errno);
39+
#endif
40+
}
41+

src/sys/Dir.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ using namespace sys;
99

1010

1111
#if defined __link
12-
#define errno link_errno
1312
Dir::Dir(link_transport_mdriver_t * driver){
1413
m_dirp = 0;
1514
m_driver = driver;
@@ -66,7 +65,7 @@ int Dir::open(const char * name){
6665
m_dirp = opendir(name);
6766
#endif
6867
if( m_dirp == 0 ){
69-
set_error_number(errno);
68+
set_error_number_to_errno();
7069
return -1;
7170
}
7271

@@ -121,8 +120,8 @@ const char * Dir::read(){
121120
#else
122121
struct dirent * result;
123122
if( readdir_r(m_dirp, &m_entry, &result) < 0 ){
124-
set_error_number(errno);
125-
return 0;
123+
set_error_number_to_errno();
124+
return 0;
126125
}
127126
#endif
128127
return m_entry.d_name;
@@ -148,7 +147,7 @@ int Dir::close(){
148147
link_closedir(driver(), m_dirp);
149148
#else
150149
if( closedir(m_dirp) < 0 ){
151-
set_error_number(errno);
150+
set_error_number_to_errno();
152151
}
153152
#endif
154153
m_dirp = 0;

src/sys/File.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
using namespace sys;
99

1010
#if defined __link
11-
#define errno link_errno
1211
File::File(link_transport_mdriver_t * d){
1312
// TODO Auto-generated constructor stub
1413
m_fd = -1; //The file is not open
@@ -165,7 +164,7 @@ int File::close(){
165164
#endif
166165
m_fd = -1;
167166
if( ret < 0 ){
168-
set_error_number(errno);
167+
set_error_number_to_errno();
169168
}
170169
}
171170
return ret;

src/sys/FileInfo.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
namespace sys {
88

99
#if defined __link
10-
#define errno link_errno
1110
FileInfo::FileInfo(link_transport_mdriver_t * d){
1211
m_driver = d;
1312
memset(&m_stat, 0, sizeof(m_stat));
@@ -26,11 +25,8 @@ int FileInfo::get_info(const char * path){
2625
#else
2726
ret = File::stat(path, &m_stat);
2827
#endif
29-
if( ret < 0 ){
30-
set_error_number(errno);
31-
}
3228

33-
return ret;
29+
return set_error_number_if_error(ret);
3430
}
3531

3632

0 commit comments

Comments
 (0)