Skip to content

Enhanced Logging with Millisecond Precision and Robust Testing #728 #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sambhavnoobcoder
Copy link


name: Pull Request
about: Create a pull request to contribute to the project
title: 'Enhanced Logging with Millisecond Precision and Robust Testing'
labels: 'enhancement, testing'
assignees: ''

Related Issue
Fixes #728

Description of Changes
This PR enhances the logging system with millisecond precision timestamps and comprehensive test coverage. Key changes include:

  1. Implemented millisecond precision in timestamps by default
  2. Added robust test suite for timestamp formatting
  3. Improved test coverage for custom timestamp formats
  4. Added proper handling of Python's logging behavior regarding milliseconds
  5. Updated documentation to reflect timestamp format options

Type of Change

  • Enhancement (non-breaking change which adds functionality)
  • Test improvement

Testing
I've added and updated several test cases to verify the logging functionality:

  • test_default_logger_format: Verifies basic timestamp format
  • test_custom_logger_format: Tests custom format with millisecond handling
  • test_millisecond_precision: Ensures millisecond precision is maintained
  • test_default_timestamp_format: Validates default timestamp behavior
  • test_custom_timestamp_format: Tests custom timestamp configurations
  • test_logging_without_config: Verifies default behavior without config

All tests are passing with 6 successful tests and 1 skipped test .
image

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run my code against examples and ensured no errors
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Timestamp in log (basic feature)
1 participant