Slightly more efficient and simplified metadata update method #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryceStevenWilley
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
LGTM! Not the most knowledgable about Postgres Jsonb, but it checks out from what I can tell.
I don't think that the speed up is really worth it, but I think having a better API for updating session metadata is good, same with getting rid of the extra tmp var we needed to delete in interviews.
Agree that a slight race condition is fine for this feature, session metadata doesn't need to be exactly in sync with on every page.
|
Also okay with merging as is, even with the failing test; it's failing because tests hadn't been running on this repo for a while; seems to be an issue with unittest mocking, but I wasn't able to figure out exactly what's wrong or how to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't seem to have a huge impact, but it might shave about 0.02s from a typical page load?
I tested this on the test_question_library.yml file and that's the difference I was seeing.
Completed processing at 0.15401s the old way, vs 0.13143s the new way. I probably didn't do enough passes to be positive, but I like the API a bit better anyway. It's not likely to be a huge impact either way.
This is part of the solution to #773 . Want to test @jpagh's idea also. But this seems safe and helpful.