Fix multiple game controllers interfering each other

[Brockengespenst]

GameControllerManager shared one button/stick state between all connected game controllers. This led to one controller interfering with other controllers in multiplayer mode.

[Brockengespenst]

Having two controllers connected and playing local multiplayer was really horrible as one player blocked the other very often. With these changes, this effect does not occur anymore. This removes the attempt to get axis and d-pad somehow kind of synchronized, but I do not really see making these changes it any worse, because it would be anyway hard to find an appropriate solution. If the button/stick state should be kept as it was, it should be added as a per controller state and not a global one.

@MatusGuy : This reverts also the changes made in 68f4717. I was not sure about the original problem, maybe you can check if these changes either reintroduce the problem you had or maybe even fix it as well.

[tobbi]

I didn't test it as I don't have multiple game controllers. But code-wise everything is fine.

[MatusGuy]

This seems to have indeed reverted my changes. I'll see what I can do

[MatusGuy]

Apply this patch and see if I haven't removed any functionality:

gamecontrollerfix.patch

[Brockengespenst]

I tested your patch. At a first glance it looked quite normal, but then I ran into a state that the second controller's stick was not able to move Tux to the right. With the D-Pad it was working, but with the stick it was not possible to move to the right (only to the left). This happend two times during a 2 minute test. I have not checked into detail what went wrong in this case and what steps exactly are needed to reproduce it.