Skip to content

Update logic to determine user authentication scenario #1150

@victor-enogwe

Description

@victor-enogwe

@tyler-dane It looks like this user has google calendars in their calendar list with the following fields undefined.

  • etag
  • accessRole
  • conferenceProperties
  • defaultReminders

We can relax the schema for these fields excepting the "accessRole" field.

Note

According to https://developers.google.com/workspace/calendar/api/v3/reference/calendarList#resource, these fields are not optional, so they should be included as part of the payload for each calendarlist item saved in Compass or Comming from Google calendar.

As part of my findings, this method here canDoIncrementalSync needs to be rethought. It is not a good method to determine whether a user should go through the signup or login phase, and allows for potential duplicate user accounts becuase we do not currently have mechanisms in place currently to prevent duplicate account creation at the database level. There is a schema change story to mitigate this #1038, but we still need to move away from determining the auth path from the ability of a user to do incremental sync.

Originally posted by @victor-enogwe in #1145

Metadata

Metadata

Assignees

No one assigned

    Labels

    backendWork related to improving the Compass API. More than 70% of the PR should be backend focused.

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions