Deploy #1
Merged
Deploy #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaleb-keny
approved these changes
Jul 22, 2025
dbeal-eth
approved these changes
Jul 23, 2025
| (, int256 currentRewardTokenRate, , uint256 updateTime, ) = rewardsTokenRateAggregator.latestRoundData(); | ||
| if (currentRewardTokenRate == 0 || updateTime < block.timestamp - 1 hours) { | ||
| (, int256 currentRewardTokenRate,, uint256 updateTime,) = rewardsTokenRateAggregator.latestRoundData(); | ||
| if (currentRewardTokenRate == 0 || updateTime < block.timestamp - 1 days - 1 hours) { |
There was a problem hiding this comment.
Nit 25 hours here probably better way to write it?
There was a problem hiding this comment.
it is quite readable and matches the report better, unless there is a technical downside - would probably be nicer this way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently having issues with invalid price feed (as snx price is 2h stale at the time of testing)