Allow server initialisation to happen outside of begin()#248
Open
webmonkey wants to merge 2 commits intoT-vK:masterfrom
Open
Allow server initialisation to happen outside of begin()#248webmonkey wants to merge 2 commits intoT-vK:masterfrom
webmonkey wants to merge 2 commits intoT-vK:masterfrom
Conversation
webmonkey
added a commit
to webmonkey/ESP32-NIMBLE-Keyboard
that referenced
this pull request
Jul 21, 2025
- originally raised in upstream T-vK/ESP32-BLE-Keyboard#248
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By separating the server initialisation from the begin() method it's possible to add other GATT services to the server before the HID services and advertisement is started later on.
This would help with situations like #73