[FEATURE] Cascade fe_group changes with extendToSubpages (reindex + cleanup) #4400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a parent page’s
fe_groupchanges andextendToSubpages=1is set, access rules effectively change for descendants as well. This PR ensures the index reflects those changes by triggering subtree reindexing and removing stale access variants.What this PR does
changeSetwildcard ('*') inAbstractUpdateHandlerto match “any change” of a field, becausefe_groupdiffs are non-trivial.extendToSubpageEnabledAndFeGroupWasChangedinDataUpdateHandlerandGarbageHandler:extendToSubpages=1andfe_groupchanged → enqueue reindex for descendants (subtree) and clean up outdated access variants/documents.How to test
extendToSubpages=1, children C1/C2 inheriting access (no localfe_group).fe_group(e.g., add/remove a frontend group).(Before this PR: descendants did not reliably reindex; stale variants remained.)
Target versions
EXT:solr 13.x (current). Backportable if maintainers agree.
Related
Fixes: #4399