Skip to content

[FEATURE] Cascade fe_group changes with extendToSubpages (reindex + cleanup) #4400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

[FEATURE] Cascade fe_group changes with extendToSubpages (reindex + cleanup) #4400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b09f33
[FEATURE] Cascade fe_group changes with extendToSubpages: changeSet w…
DavRet Aug 13, 2025
1d43db7
[TASK] Fix coding style: array indentation and blank line whitespace
DavRet Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Classes/Domain/Index/Queue/UpdateHandler/AbstractUpdateHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,13 @@ protected function getAllChangeSetValuesMatch(array $triggerConfiguration, array
return true;
}

// Return true if triggerConfiguration field value is '*' and it's key is in changedFields array
foreach ($triggerConfiguration['changeSet'] as $key => $value) {
if ($value === '*' && array_key_exists($key, $changedFields)) {
return true;
}
}

$diff = array_diff_assoc($triggerConfiguration['changeSet'], $changedFields);
return empty($diff);
}
Expand Down
5 changes: 5 additions & 0 deletions Classes/Domain/Index/Queue/UpdateHandler/DataUpdateHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ class DataUpdateHandler extends AbstractUpdateHandler
'no_search_sub_entriesFlagWasAdded' => [
'changeSet' => ['no_search_sub_entries' => '0'],
],
// the current page has the field "extendToSubpages" enabled and the field "fe_group" was changed
'extendToSubpageEnabledAndFeGroupWasChanged' => [
'currentState' => ['extendToSubpages' => '1'],
'changeSet' => ['fe_group' => '*'],
],
];

protected MountPagesUpdater $mountPageUpdater;
Expand Down
5 changes: 5 additions & 0 deletions Classes/Domain/Index/Queue/UpdateHandler/GarbageHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ class GarbageHandler extends AbstractUpdateHandler
'no_search_sub_entriesFlagWasAdded' => [
'changeSet' => ['no_search_sub_entries' => '1'],
],
// the current page has the field "extendToSubpages" enabled and the field "fe_group" was changed
'extendToSubpageEnabledAndFeGroupWasChanged' => [
'currentState' => ['extendToSubpages' => '1'],
'changeSet' => ['fe_group' => '*'],
],
];

/**
Expand Down