Skip to content

refactor(react-query-devtools): remove unnecessary export "DevtoolsOptions" and "DevtoolsPanelOptions" #9061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

refactor(react-query-devtools): remove unnecessary export "DevtoolsOptions" and "DevtoolsPanelOptions" #9061

wants to merge 3 commits into from

Conversation

minseong0324
Copy link
Contributor

DevtoolsOptions is only used within ReactQueryDevtools.tsx and DevtoolsPanelOptions is only used within ReactQueryDevtoolsPanel.tsx. so I decided that it would be better not to export them.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 23, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b8ac6a4.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 2s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-26 11:02:24 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 23, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9061

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9061

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9061

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9061

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9061

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9061

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9061

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9061

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9061

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9061

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9061

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9061

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9061

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9061

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9061

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9061

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9061

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9061

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9061

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9061

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9061

commit: b8ac6a4

@codecov Codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.00%. Comparing base (83f01cd) to head (b8ac6a4).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #9061       +/-   ##
===========================================
- Coverage   44.58%   10.00%   -34.59%     
===========================================
  Files         203        4      -199     
  Lines        8104       50     -8054     
  Branches     1809       14     -1795     
===========================================
- Hits         3613        5     -3608     
+ Misses       4059       37     -4022     
+ Partials      432        8      -424
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: react-query-devtools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@minseong0324