Skip to content

fix(router-plugin): handle explicit undefined component in code splitter #4564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wtlin1228
Copy link
Contributor

@wtlin1228 wtlin1228 commented Jul 2, 2025

Handle the edge case where options.component exists but the value is undefined.

const Route = createFileRoute('/')({
  component: undefined,
})

Before: SplitComponent is not defined -> runtime error 🚨

import React from 'react';
import { Route } from "explicit-undefined-component.tsx";
export { SplitComponent as component };

After: no SplitComponent is generated -> it works ✅

import React from 'react';
import { Route } from "explicit-undefined-component.tsx";

@schiller-manuel
Copy link
Contributor

nice! can you please rebase once we merged #4565 since the snapshots will conflict?

@wtlin1228 wtlin1228 force-pushed the handle-explicit-undefined-component branch from 373c5b6 to 2398d85 Compare July 2, 2025 23:42
@wtlin1228
Copy link
Contributor Author

@schiller-manuel done!

@wtlin1228
Copy link
Contributor Author

Oh, it hasn't been merged. I can rebase again later.

Copy link
Member

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes listed. It probably shouldn't affect any of your tests or snapshots.

@wtlin1228 wtlin1228 requested a review from SeanCassiere July 3, 2025 04:54
Copy link

nx-cloud bot commented Jul 7, 2025

View your CI Pipeline Execution ↗ for commit 065a7a3

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 5m 41s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 41s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-07 03:35:19 UTC

Copy link

pkg-pr-new bot commented Jul 7, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4564

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4564

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4564

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4564

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4564

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4564

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4564

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4564

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4564

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4564

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4564

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4564

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4564

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4564

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4564

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4564

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4564

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4564

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4564

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4564

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4564

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4564

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4564

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4564

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4564

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4564

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4564

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4564

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4564

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4564

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4564

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4564

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4564

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4564

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4564

commit: 065a7a3

@SeanCassiere SeanCassiere merged commit 84228d5 into TanStack:main Jul 7, 2025
5 checks passed
@SeanCassiere
Copy link
Member

@wtlin1228 thank you for working with us and contributing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants