-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(router-plugin): handle explicit undefined component in code splitter #4564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router-plugin): handle explicit undefined component in code splitter #4564
Conversation
nice! can you please rebase once we merged #4565 since the snapshots will conflict? |
373c5b6
to
2398d85
Compare
@schiller-manuel done! |
Oh, it hasn't been merged. I can rebase again later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the changes listed. It probably shouldn't affect any of your tests or snapshots.
View your CI Pipeline Execution ↗ for commit 065a7a3
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
@wtlin1228 thank you for working with us and contributing this! |
Handle the edge case where
options.component
exists but the value isundefined
.Before:
SplitComponent
is not defined -> runtime error 🚨After: no
SplitComponent
is generated -> it works ✅