-
Notifications
You must be signed in to change notification settings - Fork 130
feat: Revert some alloys to make crafting friendlier #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/1.21.1
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes systematically rename and replace all references to "Copper Alloy" materials, items, tags, and recipes with "Electrical Steel" equivalents throughout the codebase. This includes block and item registrations, loot tables, crafting and alloying recipes, tag providers, and relevant resource files, while maintaining backward compatibility through registry aliases. Changes
Sequence Diagram(s)sequenceDiagram
participant Game
participant Registry
participant EIOBlocks
participant EIOItems
Game->>EIOBlocks: Register blocks
EIOBlocks->>Registry: Register ELECTRICAL_STEEL_BLOCK
EIOBlocks->>Registry: Add alias "copper_alloy_block" → ELECTRICAL_STEEL_BLOCK
Game->>EIOItems: Register items
EIOItems->>Registry: Register ELECTRICAL_STEEL_INGOT, NUGGET, BALL
EIOItems->>Registry: Add aliases for old copper alloy items → electrical steel items
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Copper alloy was annoying and its requirement in conductive alloy made tier 1 energy conduits unnecessarily expensive.
c67b23d
to
5df8b86
Compare
Copper alloy was annoying and its requirement in conductive alloy made tier 1 energy conduits unnecessarily expensive.
Description
Effectively reverts #20's alloy changes.
Textures for electrical steel are from DTFuel's original contribution; https://github.com/Team-EnderIO/EnderIO/blob/dev/1.21.1/docs/license/dtfuel/alloys/license.md
These changes are made to make the resource costs make more sense.
Breaking Changes
List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Chores