Skip to content

Conversation

Rover656
Copy link
Member

@Rover656 Rover656 commented May 13, 2025

Copper alloy was annoying and its requirement in conductive alloy made tier 1 energy conduits unnecessarily expensive.

Description

Effectively reverts #20's alloy changes.

Textures for electrical steel are from DTFuel's original contribution; https://github.com/Team-EnderIO/EnderIO/blob/dev/1.21.1/docs/license/dtfuel/alloys/license.md

These changes are made to make the resource costs make more sense.

Breaking Changes

List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Summary by CodeRabbit

  • New Features

    • Introduced Electrical Steel as a new material, replacing Copper Alloy throughout the game.
    • Added animated texture for the Electrical Steel Grinding Ball.
  • Bug Fixes

    • Updated all relevant item tags, recipes, and loot tables to reference Electrical Steel instead of Copper Alloy, ensuring consistency and compatibility.
  • Chores

    • Maintained backward compatibility by redirecting old Copper Alloy references to the new Electrical Steel items and blocks.

@Rover656 Rover656 added this to the 8.0 Update milestone May 13, 2025
Copy link

coderabbitai bot commented May 13, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes systematically rename and replace all references to "Copper Alloy" materials, items, tags, and recipes with "Electrical Steel" equivalents throughout the codebase. This includes block and item registrations, loot tables, crafting and alloying recipes, tag providers, and relevant resource files, while maintaining backward compatibility through registry aliases.

Changes

File(s) Change Summary
.../common/init/EIOBlocks.java Removed COPPER_ALLOY_BLOCK, added ELECTRICAL_STEEL_BLOCK, added alias for backward compatibility.
.../common/init/EIOItems.java Replaced all COPPER_ALLOY_* items with ELECTRICAL_STEEL_* variants and updated aliases.
.../common/tag/EIOTags.java Renamed all tag keys from "copper_alloy" to "electrical_steel" in both items and blocks.
.../data/loot/ChestLootProvider.java Changed loot pool entry from COPPER_ALLOY_INGOT to ELECTRICAL_STEEL_INGOT.
.../data/recipe/ItemRecipeProvider.java Updated tool recipes to use electrical steel ingots instead of copper alloy ingots.
.../data/recipe/MaterialRecipeProvider.java Replaced copper alloy references with electrical steel in alloy and grinding ball recipes.
.../data/tags/EIOBlockTagsProvider.java Updated storage block tag from copper alloy to electrical steel.
.../data/tags/EIOItemTagsProvider.java Updated ingot, nugget, and storage block tags to use electrical steel.
.../textures/item/electrical_steel_grinding_ball.png.mcmeta Added animation metadata for the electrical steel grinding ball texture.
.../machines/data/recipes/AlloyRecipeProvider.java Replaced copper alloy ingot alloying recipe with electrical steel; updated conductive alloy recipe inputs and outputs.
.../machines/data/recipes/MachineRecipeProvider.java Updated all machine recipes to use electrical steel ingots instead of copper alloy ingots.

Sequence Diagram(s)

sequenceDiagram
    participant Game
    participant Registry
    participant EIOBlocks
    participant EIOItems

    Game->>EIOBlocks: Register blocks
    EIOBlocks->>Registry: Register ELECTRICAL_STEEL_BLOCK
    EIOBlocks->>Registry: Add alias "copper_alloy_block" → ELECTRICAL_STEEL_BLOCK

    Game->>EIOItems: Register items
    EIOItems->>Registry: Register ELECTRICAL_STEEL_INGOT, NUGGET, BALL
    EIOItems->>Registry: Add aliases for old copper alloy items → electrical steel items
Loading

Poem

In the warren of code, we hopped with zeal,
Swapping copper for steel—what a deal!
Electrical dreams now shimmer and gleam,
Recipes and tags in a sparkling new theme.
Old copper’s not lost, just wearing new shoes,
With aliases set, there’s nothing to lose!
🐇⚡


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Rover656 Rover656 marked this pull request as draft May 13, 2025 23:14
Rover656 added 2 commits May 18, 2025 22:16
Copper alloy was annoying and its requirement in conductive alloy made tier 1 energy conduits unnecessarily expensive.
@Rover656 Rover656 force-pushed the feat/alloy-revert branch from c67b23d to 5df8b86 Compare June 11, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant