Merged
Conversation
There are some unnecessary headers in `finders_interface.h` that emit warnings. This commit aims to: - remove unnecessary headers, - move necessary headers to where they're needed, and include them transitively, and - "decorate" technically unused, yet necessary-for-usage headers with `// IWYU pragma: export`.
Member
|
It compiles on CICD which tests MSVC, gcc and clang so I'd say it's alright. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some unnecessary/misplaced headers in
finders_interface.hthat emit warnings. This PR aims to:// IWYU pragma: export.I've also removed the
<list>header fromexample/main.cpp(if anyone wants to try out the API withstd::list, they can add it themselves), and added<utility>forstd::as_const().This is another minor edit to the code, but I think eliminating these warnings is worth it for further development.
Not tested yet on GCC/MSVC, I'll get to that soon (although CI/CD should tell us whether it compiles). The only caveat I can think of right now is that existing codebases could have unintentionally relied upon rectpack2D bringing in
<utility>, the only actually unused header that has been removed.