find_best_packing(): optimize required order storage to 2 * std::size(subjects)#20
Draft
lyorig wants to merge 6 commits intoTeamHypersomnia:masterfrom
Draft
find_best_packing(): optimize required order storage to 2 * std::size(subjects)#20lyorig wants to merge 6 commits intoTeamHypersomnia:masterfrom
find_best_packing(): optimize required order storage to 2 * std::size(subjects)#20lyorig wants to merge 6 commits intoTeamHypersomnia:masterfrom
Conversation
Contributor
Author
|
CI seems to have caught something weird. I'll try to look into it soon™. |
Contributor
Author
|
Oh yeah, I got some stuff completely backwards. Will try to fix if time allows for it. |
Contributor
Author
|
Checks are currently failing due to a single misplaced rectangle, which is interesting. I'm still pretty short on time, so I won't get into debugging it right away—but it may very well be caused by some trivial UB or other coding error on my part (although ASan + UBSan stayed silent). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #16.
As it stands, this PR is a rough draft cobbled together in my spare time that compiles and seems to work. There are most likely some things to improve (especially variable names), but hopefully it'll serve as a good starting point.