feat(select): support checkAll in filterable mode #3516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangchen1031
requested review from
honkinglin,
uyarn,
carolin913,
HaixingOoO,
NWYLZW and
ZWkang
as code owners
commit: |
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the checkAll feature when the Select component is in filterable mode.
- In Select.tsx, the input value is reset when applicable.
- In PopupContent.tsx, checkAllStatus is computed with useMemo and passed to child options.
- In Option.tsx, selection logic is updated to use checkAllStatus when checkAll is enabled.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/components/select/base/Select.tsx | Resets input value when reserveKeyword is false in filterable mode. |
| packages/components/select/base/PopupContent.tsx | Introduces memoized checkAllStatus for managing select-all state. |
| packages/components/select/base/Option.tsx | Updates multi-select logic to use checkAllStatus for checkAll options. |
HaixingOoO
approved these changes
Apr 27, 2025
uyarn
requested changes
Apr 28, 2025
补充了过滤时的逻辑，全选时合并、取消全选时排除 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
Select组件在filterable模式下需要支持checkAll属性
📝 更新日志
feat(select): filterable模式下支持checkAll
☑️ 请求合并前的自查清单