sts、oidc申请扮演角色临时访问支持指定endpoint #263
Merged
+248
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesky4
reviewed
Jul 25, 2025
| @@ -20,6 +20,7 @@ public class STSCredential extends Credential { | |||
| private String tmpSecretId; | |||
| private String tmpSecretKey; | |||
| private String token; | |||
| private String endpoint = "sts.tencentcloudapi.com"; | |||
| private int expiredTime; | |||
|
|
|||
| public STSCredential(String secretId, String secretKey, String roleArn, String roleSessionName) { | |||
There was a problem hiding this comment.
这里可以改成调用新的参数最全的构造函数，把默认 endpoint 从这里传进去，然后移除掉 23 行的初始化
this(secretId, secretKey, roleArn, roleSessionName, "sts.tencentcloudapi.com")
| @Override | ||
| public Response intercept(Chain chain) throws IOException { | ||
| Request request = chain.request(); | ||
| Assert.assertEquals(expectUrl, request.url().host()); |
There was a problem hiding this comment.
这样无法写出测试非 sts.tencentcloudapi.com 的测试用例
可以给 MyIntterceptor 加个 field，intercept里修改这个 field，然后在测试用例里读取这个 field，这样可以测试任意你想要的 endpoint
|
|
||
| public class OIDCRoleProviderTest { | ||
|
|
||
| class MyInterceptor implements Interceptor { |
There was a problem hiding this comment.
class 前面需要加个 static，否则 class 是和 instance 而非 class 关联起来的
|
|
||
| class MyInterceptor implements Interceptor { | ||
|
|
||
| public static final String expectUrl = "sts.tencentcloudapi.com"; |
There was a problem hiding this comment.
同 OIDCRoleProviderTest.java
| @@ -25,6 +27,7 @@ public class OIDCRoleArnProvider implements CredentialsProvider, Credential.Upda | |||
| public String WebIdentityToken; | |||
| public String RoleArn; | |||
| public String RoleSessionName; | |||
| public String Endpoint = "sts.tencentcloudapi.com"; | |||
There was a problem hiding this comment.
同 OIDCRoleProviderTest.java
并且这个 Endpoint 还要加个 getter/setter，因为有一个无参的构造函数
| field.set(null, okClient); | ||
|
|
||
| cred.getCredentials(); | ||
| } |
There was a problem hiding this comment.
还要测试下 isTke 的场景，这种情况从磁盘里读取配置，因此需要设置环境变量+临时文件，临时文件可以用 File.createTempFile()
added 2 commits
July 25, 2025 17:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.