Add manual discretization method for styles #352
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrucs
reviewed
Feb 8, 2021
src/modules/RA/DataLayer/components/tabs/StyleTab/Style/ColorListField.js
Outdated
Show resolved
Hide resolved
CFarcy
force-pushed
the
style-manual-discretization
branch
from
f04fad7 to
977748d
Compare
jrmi
reviewed
Feb 8, 2021
src/modules/RA/DataLayer/components/tabs/StyleTab/Style/ColorListField.js
Outdated
Show resolved
Hide resolved
jrmi
reviewed
Feb 8, 2021
jrmi
reviewed
Feb 8, 2021
…istField.js Co-authored-by: Jérémie Pardou-Piquemal <jeremie.pardou@makina-corpus.com>
Co-authored-by: Jérémie Pardou-Piquemal <jeremie.pardou@makina-corpus.com>
Co-authored-by: Jérémie Pardou-Piquemal <jeremie.pardou@makina-corpus.com>
jrmi
reviewed
Feb 8, 2021
| // eslint-disable-next-line react/no-array-index-key | ||
| <React.Fragment key={index}> | ||
| <Condition when={`${path}.method`} is="manual"> | ||
| <Field |
There was a problem hiding this comment.
Can't you use react-admin NumberInput here ?
jrmi
reviewed
Feb 8, 2021
| > | ||
| {({ meta, input: { value: boundValue, onChange: onBoundChange } }) => ( | ||
| <TextField | ||
| label={translate('datalayer.form.styles.step')} |
There was a problem hiding this comment.
Please use same translation prefix as other field.
jrmi
reviewed
Feb 8, 2021
| onChange={handleColorChange(index)} | ||
| /> | ||
| // eslint-disable-next-line react/no-array-index-key | ||
| <React.Fragment key={index}> |
There was a problem hiding this comment.
Is there a validation for step order ?
jrmi
reviewed
Feb 8, 2021
| const DEFAULT_MAX_CLASSES = 15; | ||
|
|
||
| const ColorListField = ({ value, onChange = () => {}, maxClasses = DEFAULT_MAX_CLASSES }) => { | ||
| const ColorListField = ({ path, value, onChange = () => {}, maxClasses = DEFAULT_MAX_CLASSES }) => { |
There was a problem hiding this comment.
It's not a colorListField anymore...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.