Cleanup of national map references and no longer used files #754
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,7 +37,6 @@ yarn.lock | |
| .yarn/releases/ | ||
|
|
||
| # wwwroot | ||
| wwwroot/public/ | ||
| wwwroot/*.html | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,95 +1,50 @@ | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <title>TerriaJS</title> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
|
|
||
| <link | ||
| href="//fonts.googleapis.com/css?family=Roboto:300,600" | ||
| rel="stylesheet" | ||
| type="text/css" | ||
| /> | ||
| <style> | ||
| * { | ||
| box-sizing: border-box; | ||
| } | ||
| body { | ||
| font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, | ||
| "Helvetica Neue", Arial, sans-serif; | ||
| height: 100vh; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| gap: 1rem; | ||
| color: #111827; | ||
| } | ||
| .error-number { | ||
| font-family: inherit; | ||
| font-size: 2.5rem; | ||
| font-weight: 600; | ||
| line-height: 1.2; | ||
| margin: 0; | ||
| padding-right: 1rem; | ||
| border-right: 1px solid #dee2e6; | ||
| } | ||
| .error-description { | ||
| font-family: inherit; | ||
| font-size: 1.25rem; | ||
| font-weight: 400; | ||
| line-height: 1.2; | ||
| margin: 0; | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <h1 class="error-number">404</h1> | ||
| <div class="inline-block align-middle"> | ||
| <h2 class="error-description" id="desc">Not found.</h2> | ||
| </div> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,94 +1,50 @@ | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <title>TerriaJS</title> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
|
|
||
| <link | ||
| href="//fonts.googleapis.com/css?family=Roboto:300,600" | ||
| rel="stylesheet" | ||
| type="text/css" | ||
| /> | ||
| <style> | ||
| * { | ||
| box-sizing: border-box; | ||
| } | ||
| body { | ||
| font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, | ||
| "Helvetica Neue", Arial, sans-serif; | ||
| height: 100vh; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| gap: 1rem; | ||
| color: #111827; | ||
| } | ||
| .error-number { | ||
| font-family: inherit; | ||
| font-size: 2.5rem; | ||
| font-weight: 600; | ||
| line-height: 1.2; | ||
| margin: 0; | ||
| padding-right: 1rem; | ||
| border-right: 1px solid #dee2e6; | ||
| } | ||
| .error-description { | ||
| font-family: inherit; | ||
| font-size: 1.25rem; | ||
| font-weight: 400; | ||
| line-height: 1.2; | ||
| margin: 0; | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <h1 class="error-number">500</h1> | ||
| <div class="inline-block align-middle"> | ||
| <h2 class="error-description" id="desc">Internal server error.</h2> | ||
|
There was a problem hiding this comment. I think headings are typically without punctuation like periods/question marks/etc. There was a problem hiding this comment. See my comment for the 400.html page. |
||
| </div> | ||
|
There was a problem hiding this comment. Could this line be retained so the user has something to click on to get to somewhere that at least doesn't give an error page? I guess the destination should be made more generic though, perhaps just calling it "the map"? There was a problem hiding this comment. It seems that we want to leave the design and the content decisions about 400.html and 500.html pages up to a particular implementation, so it makes sense to keep them very minimal. |
||
| </body> | ||
| </html> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment about no period in heading and providing a clickable link to somewhere reasonable as for the 500 page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment above about keeping it all minimal.
The punctuation here makes sense as it renders as in the picture below.