Svg sprite plugin #762
Svg sprite plugin #762
Conversation
| <link | ||
| rel="apple-touch-icon" | ||
| sizes="57x57" | ||
| href="favicons/apple-icon-57x57.png" | ||
| /> |
There was a problem hiding this comment.
are these formatting changes from prettier?
There was a problem hiding this comment.
Yes, I don't think this file was prettified before
| options: { | ||
| esModule: false, | ||
| symbolId: (svgPath) => { | ||
| namespace: (svgPath) => { |
There was a problem hiding this comment.
This namespace function is currently returning a new name for each icon in the plugin. It should instead just return the package name, something like: namespace: (svgPath) => packageNames[svgPath] || "terriajs-plugin"
There was a problem hiding this comment.
Thanks for catching this. It was definitely not intended
buildprocess/webpack.config.js
Outdated
| var args = minimist(process.argv.slice(2), { | ||
| string: ["baseHref"], | ||
| default: { baseHref: "/" } | ||
| }); |
There was a problem hiding this comment.
I think it is better to be explicit here and pass these in as parameters instead of reading directly from argv.
There was a problem hiding this comment.
Moved argv processing to the gulpfile
Depends on TerriaJS/terriajs#7689