Restore the previous behaviour when parsing positional arguments with Yargs #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
reviewed
Jun 12, 2025
| var yargs = require('yargs') | ||
| .parserConfiguration({ | ||
| "duplicate-arguments-array": false | ||
| "halt-at-non-option": true, |
There was a problem hiding this comment.
This one was my fault, sorry about that.
I remember there were some tests in the test suite initially failing so there was at least some testing of yargs, could a test be added that covers the current bug so it doesn't happen again in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #194
Now the arguments are passed correctly with either
or, in a new fashion,