-
Notifications
You must be signed in to change notification settings - Fork 389
FeatureServer fixes #7659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FeatureServer fixes #7659
Conversation
This is because metadata result changes on each call to loadMetadata() which happens often. This can cause imageryProvider to recompute unessecarily.
This is required to avoid unesseccary recompute of imageryProvider when doing things like collapsing an item on workbench.
if (!this.strata.has(ArcGisFeatureServerStratum.stratumName)) { | ||
return undefined; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loadMetadatResult
returns a new Result
object after each call to loadMetadata
which causes this method to recompute unnecessarily. Instead check if the strata exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Memoize outFields
etc. This is also required to stop the imageryProvider from re-comping when for example a user strata gets added to the object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Only issue is that requests to https://services1.arcgis.com are now being proxied through TerriaJS-server - and it is very slow. So we need to add arcgis.com
in corsDomains
I think - or remove it from allowProxyFor
Thanks @nf-s. Good point. I have created a PR here to remove arcgis.com from proxied list - TerriaJS/TerriaMap#756 |
What this PR does
clipToRectangle
trait if we want to turn off the rectangle clippingTest me
Checklist
doc/
.