Skip to content

Commit 8b84ee9

Browse files
authored
Merge pull request #3514 from mdmintz/complete-the-3.7-drop
Drop Python 3.7 leftovers
2 parents 6607492 + 0a549ce commit 8b84ee9

File tree

7 files changed

+3
-27
lines changed

7 files changed

+3
-27
lines changed

.readthedocs.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ sphinx:
1212
formats: all
1313

1414
python:
15-
version: 3.7
15+
version: 3.8
1616
install:
1717
- requirements: docs/requirements.txt
1818
- method: pip

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ See what [people are saying about Rich](https://www.willmcgugan.com/blog/pages/p
3939

4040
## Compatibility
4141

42-
Rich works with Linux, macOS and Windows. True color / emoji works with new Windows Terminal, classic terminal is limited to 16 colors. Rich requires Python 3.7 or later.
42+
Rich works with Linux, macOS and Windows. True color / emoji works with new Windows Terminal, classic terminal is limited to 16 colors. Rich requires Python 3.8 or later.
4343

4444
Rich works with [Jupyter notebooks](https://jupyter.org/) with no additional configuration required.
4545

pyproject.toml

-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ classifiers = [
1515
"Operating System :: Microsoft :: Windows",
1616
"Operating System :: MacOS",
1717
"Operating System :: POSIX :: Linux",
18-
"Programming Language :: Python :: 3.7",
1918
"Programming Language :: Python :: 3.8",
2019
"Programming Language :: Python :: 3.9",
2120
"Programming Language :: Python :: 3.10",
@@ -45,7 +44,6 @@ pytest-cov = "^3.0.0"
4544
attrs = "^21.4.0"
4645
pre-commit = "^2.17.0"
4746
asv = "^0.5.1"
48-
importlib-metadata = { version = "*", python = "<3.8" }
4947

5048
[build-system]
5149
requires = ["poetry-core>=1.0.0"]

tests/test_inspect.py

-10
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@
1313
)
1414
from rich.console import Console
1515

16-
skip_py37 = pytest.mark.skipif(
17-
sys.version_info.minor == 7 and sys.version_info.major == 3,
18-
reason="rendered differently on py3.7",
19-
)
20-
2116
skip_py38 = pytest.mark.skipif(
2217
sys.version_info.minor == 8 and sys.version_info.major == 3,
2318
reason="rendered differently on py3.8",
@@ -122,7 +117,6 @@ def test_inspect_text():
122117
assert render("Hello") == expected
123118

124119

125-
@skip_py37
126120
@skip_pypy3
127121
def test_inspect_empty_dict():
128122
expected = (
@@ -221,7 +215,6 @@ def test_inspect_integer_with_value():
221215
assert value == expected
222216

223217

224-
@skip_py37
225218
@skip_py310
226219
@skip_py311
227220
@skip_py312
@@ -259,7 +252,6 @@ def test_inspect_integer_with_methods_python38_and_python39():
259252
assert render(1, methods=True) == expected
260253

261254

262-
@skip_py37
263255
@skip_py38
264256
@skip_py39
265257
@skip_py311
@@ -302,7 +294,6 @@ def test_inspect_integer_with_methods_python310only():
302294
assert render(1, methods=True) == expected
303295

304296

305-
@skip_py37
306297
@skip_py38
307298
@skip_py39
308299
@skip_py310
@@ -347,7 +338,6 @@ def test_inspect_integer_with_methods_python311():
347338
assert render(1, methods=True) == expected
348339

349340

350-
@skip_py37
351341
@skip_pypy3
352342
def test_broken_call_attr():
353343
class NotCallable:

tests/test_pretty.py

-5
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@
1414
from rich.pretty import Node, Pretty, _ipy_display_hook, install, pprint, pretty_repr
1515
from rich.text import Text
1616

17-
skip_py37 = pytest.mark.skipif(
18-
sys.version_info.minor == 7 and sys.version_info.major == 3,
19-
reason="rendered differently on py3.7",
20-
)
2117
skip_py38 = pytest.mark.skipif(
2218
sys.version_info.minor == 8 and sys.version_info.major == 3,
2319
reason="rendered differently on py3.8",
@@ -656,7 +652,6 @@ class Foo:
656652
assert result == expected
657653

658654

659-
@skip_py37
660655
@skip_py38
661656
@skip_py39
662657
def test_attrs_broken_310() -> None:

tests/test_repr.py

-7
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import sys
21
from typing import Optional
32

43
import pytest
@@ -8,11 +7,6 @@
87

98
from inspect import Parameter
109

11-
skip_py37 = pytest.mark.skipif(
12-
sys.version_info.minor == 7 and sys.version_info.major == 3,
13-
reason="rendered differently on py3.7",
14-
)
15-
1610

1711
@rich.repr.auto
1812
class Foo:
@@ -100,7 +94,6 @@ def test_rich_repr() -> None:
10094
assert (repr(Foo("hello", bar=3))) == "Foo('hello', 'hello', bar=3, egg=1)"
10195

10296

103-
@skip_py37
10497
def test_rich_repr_positional_only() -> None:
10598
_locals = locals().copy()
10699
exec(

tox.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ minversion = 4.0.0
33
envlist =
44
lint
55
docs
6-
py{37,38,39,310,311,312,313}
6+
py{38,39,310,311,312,313}
77
isolated_build = True
88

99
[testenv]

0 commit comments

Comments
 (0)