TabbedContent and DataTable --> Switch Tab

[tmanninger]

I have a Tabbed Content.
The first Tab contains a DataTable with some BINDINGS:

("s", "switchSecondTab", "Switch to Second tab"),

When the DataTable is active and i press "s", the GUi is switching to the second tab and instantly back to the first tab.

Reverting this MR solves the issue: #4599

[github-actions]

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

[TomJGooding]

Can I just check, I assume your tab pane includes other widgets than just the DataTable?

This sounds possibly like a duplicate of #4955?

[tmanninger]

Yes, i am also have input fields in the Tab Pane.

[JeffersGlass]

I believe I'm seeing the same issue with OptionList. Here's a simple reproduction:

import uuid

from textual.app import App
from textual.widgets import Input, OptionList, TabbedContent, TabPane, Label


class MyApp(App):
    def compose(self):
        with TabbedContent():
            yield TabPane("Pane A", Input("Id"), OptionList(), id="A")

    async def on_input_submitted(self, event: Input.Submitted) -> None:
        if event.input.value:
            name = event.input.value
            event.input.value = ""
            await self.action_add_pane_and_focus(name)

    async def action_add_pane_and_focus(self, name: str | None = None):
        if not name:
            name = str(uuid.uuid4().fields[0])  # random name
        name = "_" + name                       # In case the provided name starts with a number
        tc = self.query_one(TabbedContent)
        await tc.add_pane(TabPane(name, Label(f"This is pane {name}"), id=name))
        tc.active = name


if __name__ == "__main__":
    app = MyApp()
    app.run()

The user is prompted to type a name/id for the new tab into the Input; on submitting it, a new tab/pane is created and should be focused... but as @tmanniger says focus switches to the second tab and immediately back to the first.

It looks like the OptionList is re-taking focus for some reason, causing focus to go back to the first tab:

Removing _on_descendant_focus from TabPane solves the issue (though probably breaks other things)

[JeffersGlass]

Here's the same MRE, but a little smaller and in the form of a test (which currently fails):

async def test_tabbed_content_active_focus():
    class CreateNewTabAndFocusApp(App):
        def compose(self):
            with TabbedContent():
                yield TabPane(
                    "A", Input(id="new-tab-id"), OptionList(id="options"), id="A"
                )

        async def on_input_submitted(self, event: Input.Submitted) -> None:
            await self.action_add_pane_and_focus(event.input.value)

        async def action_add_pane_and_focus(self, name: str | None = None):
            tabbed_content = self.query_one(TabbedContent)
            await tabbed_content.add_pane(TabPane(name, Label(f"Pane {name}"), id=name))
            tabbed_content.active = name

    app = CreateNewTabAndFocusApp(App)
    async with app.run_test() as pilot:
        tabbed_content = app.query_one(TabbedContent)
        assert tabbed_content.tab_count == 1
        _inp = app.query_one("Input#new-tab-id")
        await pilot.click(_inp)
        assert _inp.has_focus
        await pilot.press("B", "enter")
        await pilot.pause()
        assert tabbed_content.tab_count == 2
        assert tabbed_content.active_pane == "B"

[JeffersGlass]

Actually, it looks like it happens if there's any other focusable widget on the current tab after the input. Seems like a side-effect of the submit action jumping to the next focus.

[TomJGooding]

This looks like the same problem described in #4955 (comment) but just with added steps.

[JeffersGlass]

Yeah agreed - I got a little in the weeds trying to identify the problem and should have read through this issue a little more carefully first.

[davidfokkema]

Can this be closed as a duplicate of #4955 then?

[github-actions]

I hope I solved your issue!

Consider sponsoring my work to continue to maintain and develop Textual.

• Will McGugan