Allowing none in some CSS rules
#4982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
requested changes
Sep 11, 2024
willmcgugan
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dock: nonein Textual CSS #4977split: noneto CSS and inline Python.hatch: noneto CSS and inline Python.widget.styles(helpful popups appear in VS Code now when you hover)widget.styles.border = "none",widget.style.border_{edge} = "none",widget.style.outline = "none",widget.style.outline_{edge} = "none", which worked when using CSS but crashed with anIndexErrorwhen done inline. (Previously you could make it work by doing something like("", "red").scrollbar_size_verticalvalue was wrong inStylesBase- which was surprisngly affecting the location that notifications are rendered in. There was a subsequent workaround (margin-right: 1) inToastRackwhich I've now removed.Any others?