Skip to content

Commit 7e46feb

Browse files
authored
Merge pull request #1588 from barvirm/readfile-optimization
Refactor ReadFile function for improved performance and error handling
2 parents 735d9ed + 44374f1 commit 7e46feb

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

src/cpp/test/web-ifc-test.cpp

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,22 @@ double RandomDouble(double lo, double hi)
3131

3232
std::string ReadFile(std::string filename)
3333
{
34-
std::ifstream t(filename);
35-
std::stringstream buffer;
36-
buffer << t.rdbuf();
37-
return buffer.str();
34+
std::ifstream file(filename, std::ios::binary);
35+
if (!file) {
36+
throw std::runtime_error("Could not open file");
37+
}
38+
39+
file.seekg(0, std::ios::end);
40+
std::streamsize size = file.tellg();
41+
file.seekg(0, std::ios::beg);
42+
43+
std::string buffer(size, '\0');
44+
45+
if (!file.read(buffer.data(), size)) {
46+
throw std::runtime_error("Error reading file");
47+
}
48+
49+
return buffer;
3850
}
3951

4052
void SpecificLoadTest(webifc::parsing::IfcLoader &loader, webifc::geometry::IfcGeometryProcessor &geometryLoader, uint64_t num)

0 commit comments

Comments
 (0)