Skip to content

Refactor GetSetArgument for clarity and performance #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2025
Merged

Refactor GetSetArgument for clarity and performance #1589

merged 1 commit into from
Aug 24, 2025

Conversation

barvirm
Copy link
Contributor

@barvirm barvirm commented Aug 11, 2025

Refactor GetSetArgument for clarity and performance

  • Use a switch instead of multiple if/else
  • Reserve initial capacity for tapeOffsets to reduce reallocations
  • Replace while(true) with while(depth > 0) for clearer loop termination
  • Group similar token parsing logic to reduce code duplication

@beachtom beachtom merged commit 32352a0 into ThatOpen:main Aug 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barvirm @beachtom